[jira] [Commented] (HBASE-13994) Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98
[ https://issues.apache.org/jira/browse/HBASE-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610909#comment-14610909 ] stack commented on HBASE-13994: --- LGTM +1 Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98 Key: HBASE-13994 URL: https://issues.apache.org/jira/browse/HBASE-13994 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.14 Attachments: HBASE-13994-0.98.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13994) Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98
[
https://issues.apache.org/jira/browse/HBASE-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610836#comment-14610836
]
Andrew Purtell commented on HBASE-13994:
Looks like a bad precommit run:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.18:test
(secondPartTestsExecution) on project hbase-server: ExecutionException:
java.lang.RuntimeException: The forked VM terminated without properly saying
goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server
/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/jre/bin/java
-enableassertions -XX:MaxDirectMemorySize=1G -Xmx2800m -XX:MaxPermSize=256m
-Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true
-Djava.awt.headless=true -jar
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/target/surefire/surefirebooter6668024873047921134.jar
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/target/surefire/surefire4054841610365071419tmp
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/target/surefire/surefire_10802012333607148549769tmp
[ERROR] - [Help 1]
{noformat}
Let me resubmit.
Backport HBASE-13917 (Remove string comparison to identify request priority)
to 0.98
Key: HBASE-13994
URL: https://issues.apache.org/jira/browse/HBASE-13994
Project: HBase
Issue Type: Task
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Fix For: 0.98.14
Attachments: HBASE-13994-0.98.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13994) Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98
[ https://issues.apache.org/jira/browse/HBASE-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611032#comment-14611032 ] Andrew Purtell commented on HBASE-13994: Thank you [~stack] you are a saint. Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98 Key: HBASE-13994 URL: https://issues.apache.org/jira/browse/HBASE-13994 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.14 Attachments: HBASE-13994-0.98.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13994) Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98
[ https://issues.apache.org/jira/browse/HBASE-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611432#comment-14611432 ] Hudson commented on HBASE-13994: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #998 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/998/]) HBASE-13994 Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98 (apurtell: rev f04a68f73fc7a7b08091dbac199ace2ed3c7e0a6) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98 Key: HBASE-13994 URL: https://issues.apache.org/jira/browse/HBASE-13994 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.14 Attachments: HBASE-13994-0.98.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13994) Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98
[ https://issues.apache.org/jira/browse/HBASE-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611297#comment-14611297 ] Hudson commented on HBASE-13994: FAILURE: Integrated in HBase-0.98 #1045 (See [https://builds.apache.org/job/HBase-0.98/1045/]) HBASE-13994 Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98 (apurtell: rev f04a68f73fc7a7b08091dbac199ace2ed3c7e0a6) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98 Key: HBASE-13994 URL: https://issues.apache.org/jira/browse/HBASE-13994 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.14 Attachments: HBASE-13994-0.98.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13994) Backport HBASE-13917 (Remove string comparison to identify request priority) to 0.98
[
https://issues.apache.org/jira/browse/HBASE-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609487#comment-14609487
]
Hadoop QA commented on HBASE-13994:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12742975/HBASE-13994-0.98.patch
against 0.98 branch at commit 42d5ef017d3d629e6ca9ee93e15ac4f0f9e00ce1.
ATTACHMENT ID: 12742975
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
24 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14633//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14633//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14633//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14633//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14633//console
This message is automatically generated.
Backport HBASE-13917 (Remove string comparison to identify request priority)
to 0.98
Key: HBASE-13994
URL: https://issues.apache.org/jira/browse/HBASE-13994
Project: HBase
Issue Type: Task
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Fix For: 0.98.14
Attachments: HBASE-13994-0.98.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
