[jira] [Commented] (HBASE-14672) Exorcise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426224#comment-16426224 ] stack commented on HBASE-14672: --- Committed with wrong JIRA ID commit 094d65e6f52f5b3cb1210c4abbea2fb14bcbdf15 Author: Jonathan M HsiehDate: Wed Oct 21 16:35:50 2015 -0700 HBASE-14673 Exorcise deprecated Delete#delete* api > Exorcise deprecated Delete#delete* apis > --- > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh >Priority: Major > Fix For: 2.0.0 > > Attachments: hbase-14672-v2.patch, hbase-14672-v2.patch, > hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-14672) Exorcise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980778#comment-14980778 ] Matteo Bertozzi commented on HBASE-14672: - +1 > Exorcise deprecated Delete#delete* apis > --- > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672-v2.patch, hbase-14672-v2.patch, > hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14672) Exorcise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979058#comment-14979058 ] Hadoop QA commented on HBASE-14672: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12769306/hbase-14672-v2.patch against master branch at commit 51538c5ff89dd7ee8e32ef4895d10bfc58045b17. ATTACHMENT ID: 12769306 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 105 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16260//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16260//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16260//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16260//console This message is automatically generated. > Exorcise deprecated Delete#delete* apis > --- > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672-v2.patch, hbase-14672-v2.patch, > hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14672) Exorcise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979508#comment-14979508 ] Apekshit Sharma commented on HBASE-14672: - lgtm. +1 > Exorcise deprecated Delete#delete* apis > --- > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672-v2.patch, hbase-14672-v2.patch, > hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14672) Exorcise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973528#comment-14973528 ] Hadoop QA commented on HBASE-14672: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12768626/hbase-14672-v2.patch against master branch at commit 46c646d6154d6a5291c308e065802248f4e4e7b9. ATTACHMENT ID: 12768626 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 105 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16221//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16221//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16221//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16221//console This message is automatically generated. > Exorcise deprecated Delete#delete* apis > --- > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672-v2.patch, hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)