[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046758#comment-15046758
]
Vikas Vishwakarma commented on HBASE-14869:
---
I deployed it to a cluster and did a quick run
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047239#comment-15047239
]
Lars Hofhansl commented on HBASE-14869:
---
There's one last change I think we should do (Discussed
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047261#comment-15047261
]
Andrew Purtell commented on HBASE-14869:
+1
> Better request latency histograms
>
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047739#comment-15047739
]
Hadoop QA commented on HBASE-14869:
---
{color:red}-1 overall{color}.
Test results:
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045376#comment-15045376
]
Andrew Purtell commented on HBASE-14869:
Then if there are no objections or further comment I
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045388#comment-15045388
]
Andrew Purtell commented on HBASE-14869:
Hey [~lhofhansl], want to commit this?
> Better request
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041714#comment-15041714
]
Andrew Purtell commented on HBASE-14869:
Ok, no further concerns here
> Better request latency
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15040776#comment-15040776
]
Vikas Vishwakarma commented on HBASE-14869:
---
For the metrics I am using _SizeRangeCount_ and
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039719#comment-15039719
]
Andrew Purtell commented on HBASE-14869:
Thanks Vikas. It would be a shame if we would wish to
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039738#comment-15039738
]
Lars Hofhansl commented on HBASE-14869:
---
Cool. Metric name's the only open issue. If nobody else
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039678#comment-15039678
]
Vikas Vishwakarma commented on HBASE-14869:
---
[~apurtell] thanks for the review. We do not have
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15040770#comment-15040770
]
Vikas Vishwakarma commented on HBASE-14869:
---
[~lhofhansl] I looked at splunk where we have GC
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037746#comment-15037746
]
Vikas Vishwakarma commented on HBASE-14869:
---
the core test failure does not look related it
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038333#comment-15038333
]
Andrew Purtell commented on HBASE-14869:
The latest patches look lgtm.
Are we sure the new
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038186#comment-15038186
]
Hadoop QA commented on HBASE-14869:
---
{color:red}-1 overall{color}.
{color:green}+1 core
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035506#comment-15035506
]
Hadoop QA commented on HBASE-14869:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035567#comment-15035567
]
Vikas Vishwakarma commented on HBASE-14869:
---
will check and fix these.
> Better request
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035248#comment-15035248
]
Vikas Vishwakarma commented on HBASE-14869:
---
Attached patch for main branch also
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031581#comment-15031581
]
Vikas Vishwakarma commented on HBASE-14869:
---
added the patch 14869-v4-0.98.txt containing the
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031292#comment-15031292
]
Vikas Vishwakarma commented on HBASE-14869:
---
[~lhofhansl] please review the attached patch
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031322#comment-15031322
]
Lars Hofhansl commented on HBASE-14869:
---
-v3 looks good to me. I wonder whether it's worth to make
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030429#comment-15030429
]
Vikas Vishwakarma commented on HBASE-14869:
---
[~lhofhansl] please review the attached patch
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030687#comment-15030687
]
Lars Hofhansl commented on HBASE-14869:
---
Why not subclass MutableHistogram? Would save a bunch of
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030186#comment-15030186
]
Lars Hofhansl commented on HBASE-14869:
---
[~vik.karma] offered to finish this up. Thank you, sir!
I
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028244#comment-15028244
]
Lars Hofhansl commented on HBASE-14869:
---
Hmm... Looking at all the metrics, I also see metrics
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026291#comment-15026291
]
Lars Hofhansl commented on HBASE-14869:
---
Could also not report ranges without a hit, since we do
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022263#comment-15022263
]
Dave Latham commented on HBASE-14869:
-
We have 1 cluster where we keep everything in block cache and
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021532#comment-15021532
]
Lars Hofhansl commented on HBASE-14869:
---
So what are good default latency bands? What do people
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021615#comment-15021615
]
Yu Li commented on HBASE-14869:
---
FWIW, 0-10ms/10-100ms/100-500ms/500-1000ms/>1000ms might be enough?
And
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021477#comment-15021477
]
Yu Li commented on HBASE-14869:
---
Yes, found the totalCallTime metrics introduced by HBASE-8725 after double
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020953#comment-15020953
]
Yu Li commented on HBASE-14869:
---
{quote}
It would be better to record the number of requests in certainly
[
https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021078#comment-15021078
]
Lars Hofhansl commented on HBASE-14869:
---
I think we have histograms for all these (put time, get
32 matches
Mail list logo
