[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146922#comment-15146922
]
stack commented on HBASE-14919:
---
[~eshcar] because of the above posted FAILURE?
Nah, its not you I'd say
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146472#comment-15146472
]
Eshcar Hillel commented on HBASE-14919:
---
[~stack] I see we have some problems with the commit.
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143709#comment-15143709
]
Hudson commented on HBASE-14919:
FAILURE: Integrated in HBase-Trunk_matrix #702 (See
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143479#comment-15143479
]
Edward Bortnikov commented on HBASE-14919:
--
Awesome. Thanks to all the reviewers and of course
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143221#comment-15143221
]
stack commented on HBASE-14919:
---
I'm going to commit. If objection, shout and I'll revert.
I ran
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138218#comment-15138218
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136528#comment-15136528
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133328#comment-15133328
]
stack commented on HBASE-14919:
---
bq. Task #4 in the umbrella issue implements another ImmutableSegment
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132267#comment-15132267
]
Eshcar Hillel commented on HBASE-14919:
---
bq. Should we set -1 to when create instance of this
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131481#comment-15131481
]
Hadoop QA commented on HBASE-14919:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131891#comment-15131891
]
stack commented on HBASE-14919:
---
[~eshcar] Below are some questions:
nit: We create a snapshot on
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127288#comment-15127288
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126381#comment-15126381
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121422#comment-15121422
]
Anoop Sam John commented on HBASE-14919:
So the idea of new Memstore impl and its flush to
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121515#comment-15121515
]
Eshcar Hillel commented on HBASE-14919:
---
No problem - I can explain again:
When an external flush
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114303#comment-15114303
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114330#comment-15114330
]
stack commented on HBASE-14919:
---
No worries [~eshcar] Its an 'extant' findbugs... from before your patch.
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114306#comment-15114306
]
Eshcar Hillel commented on HBASE-14919:
---
The find bug warning is as follows
{code}
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112968#comment-15112968
]
stack commented on HBASE-14919:
---
The 82 extant findbugs are not your issue (And they have been cleaned up
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113370#comment-15113370
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113417#comment-15113417
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104887#comment-15104887
]
Eshcar Hillel commented on HBASE-14919:
---
Please advise: I think I know how to handle the
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103782#comment-15103782
]
Hadoop QA commented on HBASE-14919:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091832#comment-15091832
]
Anoop Sam John commented on HBASE-14919:
updateLowestUnflushedSequenceIdInWal () -> Tracking of
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092051#comment-15092051
]
Eshcar Hillel commented on HBASE-14919:
---
I am not sure how updateLowestUnflushedSequenceIdInWal is
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090994#comment-15090994
]
Eshcar Hillel commented on HBASE-14919:
---
It seems that this patch is ready to be committed.
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074978#comment-15074978
]
Eshcar Hillel commented on HBASE-14919:
---
Went over your comments:
1. volatile - I see what you
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073224#comment-15073224
]
stack commented on HBASE-14919:
---
I replied to the RB comments. Let me look at last posted patch.
>
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071068#comment-15071068
]
Hadoop QA commented on HBASE-14919:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065538#comment-15065538
]
Eshcar Hillel commented on HBASE-14919:
---
Sure [~stack] I understand.
Meanwhile I will start working
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062570#comment-15062570
]
Ted Yu commented on HBASE-14919:
I don't think master is stable.
See ZOOKEEPER-2347 (we recently
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062582#comment-15062582
]
Eshcar Hillel commented on HBASE-14919:
---
ok.
Just uploaded a new patch - hope to have removed all
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063198#comment-15063198
]
stack commented on HBASE-14919:
---
bq. Any chance of committing a patch while master is not stable?
I think
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060501#comment-15060501
]
Hadoop QA commented on HBASE-14919:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060512#comment-15060512
]
Ted Yu commented on HBASE-14919:
For
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061674#comment-15061674
]
Eshcar Hillel commented on HBASE-14919:
---
Thanks [~te...@apache.org] for providing the list of
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048897#comment-15048897
]
Eshcar Hillel commented on HBASE-14919:
---
The patch is now available in rb.
I will work to fix the
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047975#comment-15047975
]
Hadoop QA commented on HBASE-14919:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047994#comment-15047994
]
Ted Yu commented on HBASE-14919:
See the following for finding checkstyle warnings:
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043518#comment-15043518
]
Hadoop QA commented on HBASE-14919:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043501#comment-15043501
]
stack commented on HBASE-14919:
---
My fault [~eshcar] I broke our build environment a few days ago messing
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043498#comment-15043498
]
Eshcar Hillel commented on HBASE-14919:
---
Added link to review board.
[~yuzhihong] can you tell
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043651#comment-15043651
]
stack commented on HBASE-14919:
---
This time the patch does not apply [~eshcar] Want to rebase?
>
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038145#comment-15038145
]
Hadoop QA commented on HBASE-14919:
---
{color:red}-1 overall{color}.
{color:green}+1 core
[
https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038423#comment-15038423
]
Ted Yu commented on HBASE-14919:
168 KB is sizable.
Mind putting it on review board ?
> Infrastructure
45 matches
Mail list logo
