[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146922#comment-15146922 ] stack commented on HBASE-14919: --- [~eshcar] because of the above posted FAILURE? Nah, its not you I'd say

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-14 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146472#comment-15146472 ] Eshcar Hillel commented on HBASE-14919: --- [~stack] I see we have some problems with the commit.

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143709#comment-15143709 ] Hudson commented on HBASE-14919: FAILURE: Integrated in HBase-Trunk_matrix #702 (See

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-11 Thread Edward Bortnikov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143479#comment-15143479 ] Edward Bortnikov commented on HBASE-14919: -- Awesome. Thanks to all the reviewers and of course

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143221#comment-15143221 ] stack commented on HBASE-14919: --- I'm going to commit. If objection, shout and I'll revert. I ran

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138218#comment-15138218 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136528#comment-15136528 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133328#comment-15133328 ] stack commented on HBASE-14919: --- bq. Task #4 in the umbrella issue implements another ImmutableSegment

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-04 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132267#comment-15132267 ] Eshcar Hillel commented on HBASE-14919: --- bq. Should we set -1 to when create instance of this

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131481#comment-15131481 ] Hadoop QA commented on HBASE-14919: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-03 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131891#comment-15131891 ] stack commented on HBASE-14919: --- [~eshcar] Below are some questions: nit: We create a snapshot on

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127288#comment-15127288 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126381#comment-15126381 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121422#comment-15121422 ] Anoop Sam John commented on HBASE-14919: So the idea of new Memstore impl and its flush to

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-28 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121515#comment-15121515 ] Eshcar Hillel commented on HBASE-14919: --- No problem - I can explain again: When an external flush

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114303#comment-15114303 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-24 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114330#comment-15114330 ] stack commented on HBASE-14919: --- No worries [~eshcar] Its an 'extant' findbugs... from before your patch.

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-24 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114306#comment-15114306 ] Eshcar Hillel commented on HBASE-14919: --- The find bug warning is as follows {code}

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112968#comment-15112968 ] stack commented on HBASE-14919: --- The 82 extant findbugs are not your issue (And they have been cleaned up

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113370#comment-15113370 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14919) Infrastructure refactoring for In-Memory Flush

2016-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113417#comment-15113417 ] Hadoop QA commented on HBASE-14919: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem