[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2016-02-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136811#comment-15136811 ] Duo Zhang commented on HBASE-14949: --- {quote} It will be better if we use a switch which store in System

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2016-02-08 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137089#comment-15137089 ] Phil Yang commented on HBASE-14949: --- I think we needn't wait for upgrading finished. If we solve this

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-30 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074871#comment-15074871 ] Heng Chen commented on HBASE-14949: --- Yeah, it has little relationship with HBASE-15046. But if we

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-29 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074683#comment-15074683 ] Heng Chen commented on HBASE-14949: --- To be honest, i want to wait for HBASE-15046 results. If we move

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-29 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074690#comment-15074690 ] Duo Zhang commented on HBASE-14949: --- {quote} If we move sync WAL before update memstore, HBASE-14004

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-29 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074699#comment-15074699 ] Duo Zhang commented on HBASE-14949: --- {quote} This only happens when all datanodes crash, right? {quote}

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-29 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074695#comment-15074695 ] Heng Chen commented on HBASE-14949: --- {quote} If we do not change the logic of WAL, sync failed does not

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073391#comment-15073391 ] Duo Zhang commented on HBASE-14949: --- Talked with [~chenheng] offline. The actual difficulty here is how

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055882#comment-15055882 ] Hadoop QA commented on HBASE-14949: --- {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051961#comment-15051961 ] stack commented on HBASE-14949: --- SequenceId has a region scope. If you play an edit into a Region twice, it

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052136#comment-15052136 ] Duo Zhang commented on HBASE-14949: --- Oh, seems fine. {{DefaultMemStore}} uses a

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052064#comment-15052064 ] Duo Zhang commented on HBASE-14949: --- {quote} SequenceId has a region scope. If you play an edit into a

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052072#comment-15052072 ] Duo Zhang commented on HBASE-14949: --- And the only thing I am still a little worry about is how memstore

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052140#comment-15052140 ] stack commented on HBASE-14949: --- Should we add a test that asserts this finding/expectation? > Skip

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050958#comment-15050958 ] Heng Chen commented on HBASE-14949: --- This issue seems not as simple as i have thought yet, different

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052248#comment-15052248 ] Heng Chen commented on HBASE-14949: --- {quote} And I checked the code again, for increment and append,

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052182#comment-15052182 ] Duo Zhang commented on HBASE-14949: --- {quote} Should we add a test that asserts this

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-09 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050250#comment-15050250 ] Heng Chen commented on HBASE-14949: --- I check current logic and found that we need to do nothing..

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-08 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046654#comment-15046654 ] Phil Yang commented on HBASE-14949: --- It may be not easy to sort files with or without dup suffix. I

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046604#comment-15046604 ] Heng Chen commented on HBASE-14949: --- There are something error in this patch, maybe the wals is

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046669#comment-15046669 ] Heng Chen commented on HBASE-14949: --- {quote} name them by startID_endID {quote} Yeah, i has thought it

[jira] [Commented] (HBASE-14949) Skip duplicate entries when replay WAL.

2015-12-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047981#comment-15047981 ] Heng Chen commented on HBASE-14949: --- {quote} I use the feature wal entry id is increased one by one, so