[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253306#comment-15253306
]
Hudson commented on HBASE-15651:
FAILURE: Integrated in HBase-Trunk_matrix #865 (See
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252982#comment-15252982
]
Hadoop QA commented on HBASE-15651:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252943#comment-15252943
]
Hadoop QA commented on HBASE-15651:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252936#comment-15252936
]
Appy commented on HBASE-15651:
--
https://issues.apache.org/jira/browse/HBASE-15689
> Track our flaky tests
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252929#comment-15252929
]
Appy commented on HBASE-15651:
--
Let me create a separate jira for this.
> Track our flaky tests and use
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250799#comment-15250799
]
Dima Spivak commented on HBASE-15651:
-
Fair enough, [~appy]. Would be nice to cleanup all the Pylint,
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250659#comment-15250659
]
Hadoop QA commented on HBASE-15651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250555#comment-15250555
]
Appy commented on HBASE-15651:
--
Thanks again. Attached v4 addressing above comments.
The reason am doing
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250353#comment-15250353
]
Hadoop QA commented on HBASE-15651:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250191#comment-15250191
]
Dima Spivak commented on HBASE-15651:
-
One more round of nits and then I'm done, I promise. :)
- Line
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249246#comment-15249246
]
Hadoop QA commented on HBASE-15651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249226#comment-15249226
]
Appy commented on HBASE-15651:
--
Thanks again for the review. Attaching patch v3 with fixes.
Is there a
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249153#comment-15249153
]
Dima Spivak commented on HBASE-15651:
-
Looks so awesome, Appy! For anyone who wants to see what this
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249147#comment-15249147
]
Hadoop QA commented on HBASE-15651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249112#comment-15249112
]
Appy commented on HBASE-15651:
--
Thanks for the great review [~dimaspivak].
Addressed all the comments in the
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248805#comment-15248805
]
Dima Spivak commented on HBASE-15651:
-
Great stuff overall, [~appy]. Some thoughts:
- Best practice
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248768#comment-15248768
]
stack commented on HBASE-15651:
---
Talking about the bit on the end...
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248766#comment-15248766
]
stack commented on HBASE-15651:
---
I tried it:
{code}
kalashnikov:hbase.git stack$ python
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246651#comment-15246651
]
Appy commented on HBASE-15651:
--
Good to commit now.
> Track our flaky tests and use them to improve our
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244016#comment-15244016
]
Hadoop QA commented on HBASE-15651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242470#comment-15242470
]
stack commented on HBASE-15651:
---
Script is missing apache license.
Does this if I pass it general Trunk
[
https://issues.apache.org/jira/browse/HBASE-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240657#comment-15240657
]
Appy commented on HBASE-15651:
--
Script attached.
> Track our flaky tests and use them to improve our build
22 matches
Mail list logo
