[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327603#comment-15327603 ] Hudson commented on HBASE-15991: FAILURE: Integrated in HBase-Trunk_matrix #1041 (See

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327240#comment-15327240 ] ramkrishna.s.vasudevan commented on HBASE-15991: Pushed again. Thanks for the feedback

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327184#comment-15327184 ] Eshcar Hillel commented on HBASE-15991: --- In that case, among all blocking options

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327170#comment-15327170 ] ramkrishna.s.vasudevan commented on HBASE-15991: I think the current patch is fine. Can I

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327172#comment-15327172 ] Hudson commented on HBASE-15991: FAILURE: Integrated in HBase-Trunk_matrix #1040 (See

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327078#comment-15327078 ] ramkrishna.s.vasudevan commented on HBASE-15991: I reverted the commit for further

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326928#comment-15326928 ] ramkrishna.s.vasudevan commented on HBASE-15991: Currently there is no need for a size

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326925#comment-15326925 ] ramkrishna.s.vasudevan commented on HBASE-15991: Oops. I think my commit and your commit

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326918#comment-15326918 ] Eshcar Hillel commented on HBASE-15991: --- Some comments: 1. The exception is due to StealJobQueue

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-13 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326909#comment-15326909 ] ramkrishna.s.vasudevan commented on HBASE-15991: I will commit the patch as is. I think

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-11 Thread Anastasia Braginsky (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326015#comment-15326015 ] Anastasia Braginsky commented on HBASE-15991: - The change looks reasonable for me. >

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324311#comment-15324311 ] Hadoop QA commented on HBASE-15991: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-10 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324128#comment-15324128 ] Anoop Sam John commented on HBASE-15991: There is test available in Test class for in memory

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323891#comment-15323891 ] ramkrishna.s.vasudevan commented on HBASE-15991: Yes. Configure a table with a CF that

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323885#comment-15323885 ] Anoop Sam John commented on HBASE-15991: When use the CompactingMemstore and an in memory flush

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323876#comment-15323876 ] ramkrishna.s.vasudevan commented on HBASE-15991: bq.can you give some background on this

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread Eshcar Hillel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323275#comment-15323275 ] Eshcar Hillel commented on HBASE-15991: --- [~anoop.hbase], [~ram_krish], can you give some background

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322429#comment-15322429 ] Hadoop QA commented on HBASE-15991: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322336#comment-15322336 ] Anoop Sam John commented on HBASE-15991: Ping [~anastas], [~eshcar] >

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-09 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322333#comment-15322333 ] Anoop Sam John commented on HBASE-15991: Looks good to me >

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-08 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320538#comment-15320538 ] ramkrishna.s.vasudevan commented on HBASE-15991: Ya simple Q should suffice here because

[jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator

2016-06-08 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320532#comment-15320532 ] Anoop Sam John commented on HBASE-15991: Not sure whether we really need a StealJobQueue here for