[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493675#comment-15493675
]
Hudson commented on HBASE-16229:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1606 (See
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487059#comment-15487059
]
Hudson commented on HBASE-16229:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1593 (See
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486110#comment-15486110
]
Anoop Sam John commented on HBASE-16229:
Have a +1 in RB from Ram.
Will fix the nits on commit
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484739#comment-15484739
]
ramkrishna.s.vasudevan commented on HBASE-16229:
Pls add the latest patch to RB. Ignore
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483824#comment-15483824
]
Hadoop QA commented on HBASE-16229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483597#comment-15483597
]
Anastasia Braginsky commented on HBASE-16229:
-
Great!!!
> Cleaning up size and heapSize
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483534#comment-15483534
]
Anoop Sam John commented on HBASE-16229:
Thanks for the great reviews.. Addressed all ur
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481437#comment-15481437
]
Anastasia Braginsky commented on HBASE-16229:
-
I have finished the code review. Please refer
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15462975#comment-15462975
]
Anastasia Braginsky commented on HBASE-16229:
-
Hey, you have done a great job with this
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460332#comment-15460332
]
stack commented on HBASE-16229:
---
+1 Straight-forward rename (w/ nice making of HBaseRpController an
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451683#comment-15451683
]
Hadoop QA commented on HBASE-16229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449624#comment-15449624
]
Anoop Sam John commented on HBASE-16229:
May be a new version required with slight modification
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449007#comment-15449007
]
Hadoop QA commented on HBASE-16229:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448751#comment-15448751
]
Anastasia Braginsky commented on HBASE-16229:
-
I took a look, the comments still mostly
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448747#comment-15448747
]
Anastasia Braginsky commented on HBASE-16229:
-
Strange... I am getting mails from the RB when
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448731#comment-15448731
]
Anoop Sam John commented on HBASE-16229:
Now only I noticed those comments. Strange. The RB tool
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448486#comment-15448486
]
Anastasia Braginsky commented on HBASE-16229:
-
The test case correction -- tell me about
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448471#comment-15448471
]
Anoop Sam John commented on HBASE-16229:
Ya Segment only handling its size. The overhead only it
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448453#comment-15448453
]
Anastasia Braginsky commented on HBASE-16229:
-
Why not to let the Segment (mutable and
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448372#comment-15448372
]
Hadoop QA commented on HBASE-16229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422845#comment-15422845
]
Anastasia Braginsky commented on HBASE-16229:
-
I have made a review to the current version of
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418783#comment-15418783
]
Anastasia Braginsky commented on HBASE-16229:
-
I see. Let me go once again through your code
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418395#comment-15418395
]
Anoop Sam John commented on HBASE-16229:
Gone through it.. That is what exactly this is trying to
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417174#comment-15417174
]
Anastasia Braginsky commented on HBASE-16229:
-
I think I can not attach a file here, so
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393534#comment-15393534
]
Anastasia Braginsky commented on HBASE-16229:
-
Thank you very much!
> Cleaning up size and
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393527#comment-15393527
]
Anoop Sam John commented on HBASE-16229:
very much ok. will get 14921 committed first.
>
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393519#comment-15393519
]
Anastasia Braginsky commented on HBASE-16229:
-
So, based on all the comments in HBASE-14921,
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391413#comment-15391413
]
Anoop Sam John commented on HBASE-16229:
https://reviews.apache.org/r/50384/
> Cleaning up size
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391032#comment-15391032
]
Anastasia Braginsky commented on HBASE-16229:
-
Very long patch, can you please put it on
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391029#comment-15391029
]
Anastasia Braginsky commented on HBASE-16229:
-
I found this JIRA due to Code Review of
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382409#comment-15382409
]
Anoop Sam John commented on HBASE-16229:
I did not notice that javadoc saying we dont account the
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381814#comment-15381814
]
ramkrishna.s.vasudevan commented on HBASE-16229:
The DEEP_OVERHEAD_PER_PIPELINE_ITEM is
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380563#comment-15380563
]
Hadoop QA commented on HBASE-16229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379349#comment-15379349
]
Hadoop QA commented on HBASE-16229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376590#comment-15376590
]
Anoop Sam John commented on HBASE-16229:
This also looks odd
MemstoreCompactor
{code}
private
35 matches
Mail list logo
