[jira] [Commented] (HBASE-16322) Disable filter for raw scan

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137953#comment-16137953
 ] 

Duo Zhang commented on HBASE-16322:
---

Finally I found that we do have some usage that filter and raw scan are used 
together. For example, for canary, we will use raw scan and a 
{{FirstKeyOnlyFilter}}, and the filter still works with delete marker. So maybe 
just add a flag to the current filter which indicate whether it can work with 
delete marker? Then we can use them in raw scan and also in compaction(for CP 
hook).

Thanks.

> Disable filter for raw scan
> ---
>
> Key: HBASE-16322
> URL: https://issues.apache.org/jira/browse/HBASE-16322
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>
> As we will pass delete markers to the filter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16322) Disable filter for raw scan

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927276#comment-15927276
 ] 

Duo Zhang commented on HBASE-16322:
---

I think these filters are private and only used at server side?

The point here is that, the current filter is not designed to deal with delete 
marker, and it is too powerful for our server side usage. I'm not familiar with 
AccessControlFilter and VisibilityLabelFilter but I guess cell level filter is 
enough for them? There is a issue for introducing a new filter that can only be 
used at server side, HBASE-16323.

Thanks.

> Disable filter for raw scan
> ---
>
> Key: HBASE-16322
> URL: https://issues.apache.org/jira/browse/HBASE-16322
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>
> As we will pass delete markers to the filter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-16322) Disable filter for raw scan

[Chia-Ping Tsai (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927140#comment-15927140
 ] 

Chia-Ping Tsai commented on HBASE-16322:


Does the security still work if we disable the filter for raw scan ? How do we 
use the AccessControlFilter and VisibilityLabelFilter for the raw scan? 

> Disable filter for raw scan
> ---
>
> Key: HBASE-16322
> URL: https://issues.apache.org/jira/browse/HBASE-16322
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>
> As we will pass delete markers to the filter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-16322) Disable filter for raw scan

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516527#comment-15516527
 ] 

Duo Zhang commented on HBASE-16322:
---

Ah it is not allowed to specify columns for a raw scan...

{code:title=StoreScanner.java}
if (columns != null && scan.isRaw()) {
  throw new DoNotRetryIOException("Cannot specify any column for a raw 
scan");
}
{code}

I think we could add more checks here to disable other options such as filter.

And seems it is difficult to add deprecated annotations for scan on branch-1? 
We should not mark setFilter as Deprecated as we only do not want to use it 
together with raw scan... Is documentation enough for warning that a feature 
will be disabled in the next major release?

Thanks.

> Disable filter for raw scan
> ---
>
> Key: HBASE-16322
> URL: https://issues.apache.org/jira/browse/HBASE-16322
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>
> As we will pass delete markers to the filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-16322) Disable filter for raw scan

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516345#comment-15516345
 ] 

Duo Zhang commented on HBASE-16322:
---

As [~yangzhe1991] has made some progress in HBASE-15968, let's pick this up.

For raw scan, I think the only useful options are family and qualifier. OK, 
time range is also a possible useful option. All others options should be 
disabled for a raw scan.

So here I propose that we just remove the filter and version counting logic in 
raw scan to simplify the work in HBASE-15968. Or at least, they do not need to 
consider whether the logic works for raw scan.

Thanks.

> Disable filter for raw scan
> ---
>
> Key: HBASE-16322
> URL: https://issues.apache.org/jira/browse/HBASE-16322
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>
> As we will pass delete markers to the filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)