[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507631#comment-15507631 ] Hudson commented on HBASE-16646: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1642 (See

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507063#comment-15507063 ] Hadoop QA commented on HBASE-16646: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506616#comment-15506616 ] Ted Yu commented on HBASE-16646: The added run method checks config parameter such as SILENCE_CONF_KEY. I

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-20 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505820#comment-15505820 ] Ashish Singhi commented on HBASE-16646: --- bq. import java.util.HashMap; Unused import, not sure why

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-20 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505717#comment-15505717 ] Jerry He commented on HBASE-16646: -- Is it possible that we don't have the added run method? > Enhance

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505283#comment-15505283 ] Ted Yu commented on HBASE-16646: Failed tests passed locally with patch: {code} Running

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505215#comment-15505215 ] Hadoop QA commented on HBASE-16646: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-19 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503447#comment-15503447 ] Ashish Singhi commented on HBASE-16646: --- Since this is a public and stable class, IMHO its better

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503427#comment-15503427 ] Ted Yu commented on HBASE-16646: For test case, that would be covered by HBASE-14417. Is that Okay ?

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-19 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503283#comment-15503283 ] Ashish Singhi commented on HBASE-16646: --- bq. public int run(String dirPath, Map map,

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498121#comment-15498121 ] Ted Yu commented on HBASE-16646: Patch v2 fixes javadoc and findbugs warnings. > Enhance

[jira] [Commented] (HBASE-16646) Enhance LoadIncrementalHFiles API to accept store file paths as input

2016-09-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498088#comment-15498088 ] Hadoop QA commented on HBASE-16646: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem