[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708960#comment-15708960
]
Hudson commented on HBASE-17178:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2047 (See
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708697#comment-15708697
]
Hudson commented on HBASE-17178:
SUCCESS: Integrated in Jenkins build HBase-1.4 #552 (See
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708366#comment-15708366
]
Hadoop QA commented on HBASE-17178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708146#comment-15708146
]
Guanghao Zhang commented on HBASE-17178:
Thanks [~yangzhe1991] [~tedyu] [~carp84] [~ashish
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708095#comment-15708095
]
Phil Yang commented on HBASE-17178:
---
I'll fix whitespace warning while committing.
> Add region
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708086#comment-15708086
]
Hadoop QA commented on HBASE-17178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707949#comment-15707949
]
Ashish Singhi commented on HBASE-17178:
---
+1
> Add region balance throttling
>
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707923#comment-15707923
]
Hadoop QA commented on HBASE-17178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707838#comment-15707838
]
Hadoop QA commented on HBASE-17178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707683#comment-15707683
]
Ashish Singhi commented on HBASE-17178:
---
I left some very minor comments on RB.
Thanks.
> Add
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707652#comment-15707652
]
Phil Yang commented on HBASE-17178:
---
Thanks [~carp84]. Will commit if QA pass.
> Add region balance
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707644#comment-15707644
]
Yu Li commented on HBASE-17178:
---
+1 on v5 patch
> Add region balance throttling
>
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707454#comment-15707454
]
Hadoop QA commented on HBASE-17178:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707345#comment-15707345
]
Yu Li commented on HBASE-17178:
---
Overall LGTM, +1. Left some comment in RB, please check it there. Thanks.
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707188#comment-15707188
]
Guanghao Zhang commented on HBASE-17178:
Review board: https://reviews.apache.org/r/54191/
bq.
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705686#comment-15705686
]
Yu Li commented on HBASE-17178:
---
{code}
+int maxRegionsInTransition = getMaxRegionsInTransition();
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705328#comment-15705328
]
Phil Yang commented on HBASE-17178:
---
Let's wait more reviews.
[~zghaobac] Please prepare a patch for
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705300#comment-15705300
]
Hadoop QA commented on HBASE-17178:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705078#comment-15705078
]
Hadoop QA commented on HBASE-17178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705012#comment-15705012
]
Phil Yang commented on HBASE-17178:
---
+1 on v3 patch. Let's see QA result.
> Add region balance
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704849#comment-15704849
]
Phil Yang commented on HBASE-17178:
---
Discussed with [~zghaobac] offline. Throttling logic should be
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704809#comment-15704809
]
Phil Yang commented on HBASE-17178:
---
And I am not sure if 0.01 is a good default value because
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704792#comment-15704792
]
Phil Yang commented on HBASE-17178:
---
{code}
double maxRitPercent =
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704791#comment-15704791
]
Guanghao Zhang commented on HBASE-17178:
Agreed. The max ratio is better than an absolute value
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704065#comment-15704065
]
Phil Yang commented on HBASE-17178:
---
Maybe we need a config to limit the max ratio of RIT regions? From
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703912#comment-15703912
]
Guanghao Zhang commented on HBASE-17178:
Good idea. When RIT duration is longer than we expected,
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703856#comment-15703856
]
Dave Latham commented on HBASE-17178:
-
The goal of both, from what I can tell is to limit the
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703628#comment-15703628
]
Guanghao Zhang commented on HBASE-17178:
Thanks for your help. The goal of HBASE-12890 is to
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702704#comment-15702704
]
Phil Yang commented on HBASE-17178:
---
If I am not wrong, we are going to limit the concurrent RIT
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702225#comment-15702225
]
Dave Latham commented on HBASE-17178:
-
See HBASE-12890 for some related discussion / implementation
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701859#comment-15701859
]
Hadoop QA commented on HBASE-17178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701763#comment-15701763
]
Ted Yu commented on HBASE-17178:
{code}
221 public long getRitTime() {
{code}
getRitDuration would
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701720#comment-15701720
]
Guanghao Zhang commented on HBASE-17178:
The v1 patch didn't recorded the average time of RIT in
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700949#comment-15700949
]
Guanghao Zhang commented on HBASE-17178:
We have been used hbase.balancer.max.balancing.regions
[
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700860#comment-15700860
]
Yu Li commented on HBASE-17178:
---
+1 on the idea to throttle the region number moved in each iteration, we
35 matches
Mail list logo
