[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895432#comment-15895432 ] Hadoop QA commented on HBASE-17465: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895396#comment-15895396 ] Enis Soztutar commented on HBASE-17465: --- bq. BTW, I have problems of running make lint, e.g. Hmm,

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895380#comment-15895380 ] Xiaobing Zhou commented on HBASE-17465: --- v11 posted. It addressed all your latest comments except I

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895277#comment-15895277 ] Enis Soztutar commented on HBASE-17465: --- Also, can you address this warning: {code}

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895264#comment-15895264 ] Enis Soztutar commented on HBASE-17465: --- bq. I've filed two tickets as follow up work. Thanks,

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895146#comment-15895146 ] Xiaobing Zhou commented on HBASE-17465: --- I've filed two tickets as follow up work. HBASE-17726 and

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895057#comment-15895057 ] Hadoop QA commented on HBASE-17465: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-03 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894996#comment-15894996 ] Xiaobing Zhou commented on HBASE-17465: --- v10 did rebase. > [C++] implement request retry mechanism

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-03-01 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891461#comment-15891461 ] Xiaobing Zhou commented on HBASE-17465: --- posted v9 #fixed broken promise #removed AsyncConnection

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-02-27 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886795#comment-15886795 ] Xiaobing Zhou commented on HBASE-17465: --- Thanks [~enis], I will post next patch to address your

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-02-10 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862125#comment-15862125 ] Enis Soztutar commented on HBASE-17465: --- bq. It is fine if you want to do this in a future patch.

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-02-10 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861989#comment-15861989 ] Enis Soztutar commented on HBASE-17465: --- Thanks [~xiaobingo] for the patches. I was able to

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-02-03 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852356#comment-15852356 ] Xiaobing Zhou commented on HBASE-17465: --- posted v7. # added unit tests # simplified generic

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-31 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847685#comment-15847685 ] Xiaobing Zhou commented on HBASE-17465: --- Posted v6 to add SERVICE template parameter for easy mock

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-27 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843587#comment-15843587 ] Xiaobing Zhou commented on HBASE-17465: --- Thank you [~enis] for reviews. # HBaseRpcController

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-27 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843576#comment-15843576 ] Xiaobing Zhou commented on HBASE-17465: --- Posted patch v5. # added more exception related

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-26 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840871#comment-15840871 ] Enis Soztutar commented on HBASE-17465: --- Thanks [~xiaobingo] for working on this. It is a pretty

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-25 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838801#comment-15838801 ] Xiaobing Zhou commented on HBASE-17465: --- posted v4 that implements generic

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-20 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832702#comment-15832702 ] Xiaobing Zhou commented on HBASE-17465: --- posted v3. # added AsyncSingleRequestRpcRetryingCaller

[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC

2017-01-20 Thread Xiaobing Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832592#comment-15832592 ] Xiaobing Zhou commented on HBASE-17465: --- v2 implemented SingleRequestCallerBuilder. > [C++]