[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363368#comment-16363368 ] Appy commented on HBASE-17472: -- Sorry for ultra late review. Seeing the final patch which was committed to

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875290#comment-15875290 ] Zheng Hu commented on HBASE-17472: -- Really thanks [~Apache9]'s help. I update this issue with release

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874913#comment-15874913 ] Hudson commented on HBASE-17472: SUCCESS: Integrated in Jenkins build HBase-1.4 #636 (See

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874729#comment-15874729 ] Hudson commented on HBASE-17472: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2539 (See

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874252#comment-15874252 ] Duo Zhang commented on HBASE-17472: --- Oh, sorry. Will commit it this evening. Thanks. > Correct the

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874200#comment-15874200 ] Zheng Hu commented on HBASE-17472: -- Ping [~Apache9], [~enis], [~busbey], Thanks. > Correct the

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872896#comment-15872896 ] huzheng commented on HBASE-17472: - Any concerns ? [~Apache9]], [~enis], [~busbey], Thanks. > Correct

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871318#comment-15871318 ] Hadoop QA commented on HBASE-17472: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871263#comment-15871263 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871148#comment-15871148 ] huzheng commented on HBASE-17472: - Upload patch v7 for removing all grant2. > Correct the semantic of

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871070#comment-15871070 ] huzheng commented on HBASE-17472: - Oh... Sorry, Will upload a new patch. Thanks [~enis] > Correct the

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870790#comment-15870790 ] Enis Soztutar commented on HBASE-17472: --- please remove all mentions of "grant2" from the method

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870369#comment-15870369 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870108#comment-15870108 ] huzheng commented on HBASE-17472: - [~Apache9], Thanks for reminding . Upload patch for branch-1, the

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869895#comment-15869895 ] Duo Zhang commented on HBASE-17472: --- I think master and branch-1 is enough. We do not need to commit

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869882#comment-15869882 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869707#comment-15869707 ] huzheng commented on HBASE-17472: - Upload patch for branch-1.3: Provide a extra grant(...,

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869669#comment-15869669 ] Hadoop QA commented on HBASE-17472: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869660#comment-15869660 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869415#comment-15869415 ] huzheng commented on HBASE-17472: - Patch for branch-1 will be different, I'll upload it later. >

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869412#comment-15869412 ] huzheng commented on HBASE-17472: - Upload patch v6 for master branch : 1. remove grant2 method in

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868997#comment-15868997 ] Sean Busbey commented on HBASE-17472: - +1 to making the flag compatible on branch-1 and default to

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868996#comment-15868996 ] huzheng commented on HBASE-17472: - Thanks [~busbey], [~enis], [~Apache9], new patch with a flag will

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868939#comment-15868939 ] Duo Zhang commented on HBASE-17472: --- Oh sorry, in the patch here we already have a

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868937#comment-15868937 ] Duo Zhang commented on HBASE-17472: --- So let's introduce a flag called overwrite? in branch-1 it is

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868384#comment-15868384 ] Enis Soztutar commented on HBASE-17472: --- bq. Can we do this as a flag on a single grant command

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868115#comment-15868115 ] Sean Busbey commented on HBASE-17472: - I'd even go so far as having the flag indicate the user wants

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868048#comment-15868048 ] Sean Busbey commented on HBASE-17472: - Can we do this as a flag on a single grant command please? an

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867884#comment-15867884 ] huzheng commented on HBASE-17472: - Hi [~Apache9], I've created HBASE-17651 for it. > Correct the

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867850#comment-15867850 ] Duo Zhang commented on HBASE-17472: --- Will commit tomorrow if no objections. And [~openinx] please open

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867687#comment-15867687 ] Hadoop QA commented on HBASE-17472: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867469#comment-15867469 ] huzheng commented on HBASE-17472: - Upload patch v5. 1. set default value to false for new fields

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867350#comment-15867350 ] Hadoop QA commented on HBASE-17472: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867173#comment-15867173 ] huzheng commented on HBASE-17472: - Upload patch v4.According to review comments, patch v4 remove

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865782#comment-15865782 ] huzheng commented on HBASE-17472: - Thanks [~Apache9], I will upload a new patch for your review comment.

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865134#comment-15865134 ] Duo Zhang commented on HBASE-17472: --- Will take a look later today. > Correct the semantic of

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865132#comment-15865132 ] huzheng commented on HBASE-17472: - [~ashish singhi], [~Apache9], [~zghaobac] Could you help to review

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857476#comment-15857476 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857355#comment-15857355 ] huzheng commented on HBASE-17472: - Upload patch v3: 1. add java docs for grant/grant2 API. 2. fix

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856257#comment-15856257 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856232#comment-15856232 ] Hadoop QA commented on HBASE-17472: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855994#comment-15855994 ] huzheng commented on HBASE-17472: - Upload patch v2, which remove unnecessary modifications. > Correct

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855954#comment-15855954 ] huzheng commented on HBASE-17472: - I've uploaded a patch v1 , which implement a new RPC API named grant2

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823708#comment-15823708 ] huzheng commented on HBASE-17472: - [~Apache9][~ashish singhi] [~Weizhan Zeng] thanks for your advise,

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823695#comment-15823695 ] Ashish Singhi commented on HBASE-17472: --- bq. Can we add hint for grant command after we change the

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823684#comment-15823684 ] Weizhan Zeng commented on HBASE-17472: -- +1 > 1. Grant command add (not replace) one or more

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823543#comment-15823543 ] huzheng commented on HBASE-17472: - [~ashish singhi] , Your concern is reasonable . Can we add hint

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823501#comment-15823501 ] Duo Zhang commented on HBASE-17472: --- Add new commands and deprecate the old commands maybe? > Correct

[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant

[ https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823484#comment-15823484 ] Ashish Singhi commented on HBASE-17472: --- This behavior exists in HBase from more than 3 years now.