[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-27 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886069#comment-15886069
 ] 

Ted Yu commented on HBASE-17689:


Logged HBASE-17703 for flaky TestThriftServerCmdLine.

> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>  Labels: thrift2
> Attachments: HBASE-17689.patch
>
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-27 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885933#comment-15885933
 ] 

Ted Yu commented on HBASE-17689:


TestThriftServerCmdLine failure was not related.

> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>  Labels: thrift2
> Attachments: HBASE-17689.patch
>
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-26 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885177#comment-15885177
 ] 

Hadoop QA commented on HBASE-17689:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
30s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
59s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 9s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 6s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 46s {color} 
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
7s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 0s {color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.thrift.TestThriftServerCmdLine |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12854815/HBASE-17689.patch |
| JIRA Issue | HBASE-17689 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux a9e906d68d1a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 4d90425 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5848/artifact/patchprocess/patch-unit-hbase-thrift.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/5848/artifact/patchprocess/patch-unit-hbase-thrift.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5848/testReport/ |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5848/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
>

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-25 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884218#comment-15884218
 ] 

Ted Yu commented on HBASE-17689:


Please generate patch for master branch.

> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>  Labels: thrift2
> Attachments: HBASE-17689.patch
>
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884216#comment-15884216
 ] 

Hadoop QA commented on HBASE-17689:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s {color} 
| {color:red} HBASE-17689 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12854437/HBASE-17689.patch |
| JIRA Issue | HBASE-17689 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5838/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>  Labels: thrift2
> Attachments: HBASE-17689.patch
>
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-24 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883952#comment-15883952
 ] 

Ted Yu commented on HBASE-17689:


{code}
41  import java.util.*;
{code}
Please don't use wildcard import.

> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>  Labels: thrift2
> Attachments: HBASE-17689.patch
>
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-23 Thread Yechao Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882077#comment-15882077
 ] 

Yechao Chen commented on HBASE-17689:
-

[~xieliang007] I want to add this method to THBaseservice,please have a look.

> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17689) hbase thrift2 THBaseservice support table.existsAll

2017-02-23 Thread Yechao Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882066#comment-15882066
 ] 

Yechao Chen commented on HBASE-17689:
-

ThriftHBaseServiceHandler.java add a method 
  @Override
  public List existsAll(ByteBuffer table, List gets) throws 
TIOError, TException {
Table htable = getTable(table);
try {
  boolean[] exists = htable.existsAll(getsFromThrift(gets));
  List result = new ArrayList<>();
  for (boolean exist : exists) {
result.add(exist);
  }
  return result;
} catch (IOException e) {
  throw getTIOError(e);
} finally {
  closeTable(htable);
}
  }


> hbase thrift2 THBaseservice support table.existsAll
> ---
>
> Key: HBASE-17689
> URL: https://issues.apache.org/jira/browse/HBASE-17689
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yechao Chen
>
> hbase thrift2  support  existsAll(List gets) throws IOException;
> hbase.thrift add a method to service THBaseService like this
> list existsAll(
>   1: required binary table,
>   2: required list tgets
> ) throws (1:TIOError io)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)