[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990422#comment-15990422
]
Hudson commented on HBASE-17872:
ABORTED: Integrated in Jenkins build HBase-HBASE-14614 #190 (See
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962246#comment-15962246
]
Hudson commented on HBASE-17872:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2829 (See
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961887#comment-15961887
]
Chia-Ping Tsai commented on HBASE-17872:
bq. It is a pain doing all the reflection code but thank
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961858#comment-15961858
]
stack commented on HBASE-17872:
---
That is a very nice improvement [~chia7712]. +1.
It is a pain doing all
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961799#comment-15961799
]
Hadoop QA commented on HBASE-17872:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961642#comment-15961642
]
Chia-Ping Tsai commented on HBASE-17872:
bq. Are the test failures related? Seems unlikely.
They
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961312#comment-15961312
]
stack commented on HBASE-17872:
---
Are the test failures related? Seems unlikely.
On patch, will the change
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960268#comment-15960268
]
ramkrishna.s.vasudevan commented on HBASE-17872:
+1 on v3. Sorry for missing out on the
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960262#comment-15960262
]
Hadoop QA commented on HBASE-17872:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959990#comment-15959990
]
Chia-Ping Tsai commented on HBASE-17872:
bq. Then it becomes how to change a static final setting
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959485#comment-15959485
]
Hadoop QA commented on HBASE-17872:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959307#comment-15959307
]
Chia-Ping Tsai commented on HBASE-17872:
bq. Volatile reads are way more expensive than a local
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959268#comment-15959268
]
Anoop Sam John commented on HBASE-17872:
Thanks Stack.. My bad.. I did not really realize that
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959250#comment-15959250
]
stack commented on HBASE-17872:
---
Seems a pity making runtime pay the price of test-time convenience.
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958968#comment-15958968
]
Ted Yu commented on HBASE-17872:
+1, pending QA.
> The MSLABImpl generates the invaild cells when unsafe
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958849#comment-15958849
]
Chia-Ping Tsai commented on HBASE-17872:
bq. I suggest changing the above method to
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958750#comment-15958750
]
Ted Yu commented on HBASE-17872:
Can TestFromClientSide3WoUnsafe be structured in such a way that the two
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958713#comment-15958713
]
Ted Yu commented on HBASE-17872:
{code}
59public static void tryEnableUnsafe() {
{code}
Since
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958620#comment-15958620
]
Chia-Ping Tsai commented on HBASE-17872:
TestZKSecretWatcher pass locally. It is unrelated to
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958598#comment-15958598
]
Hadoop QA commented on HBASE-17872:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958432#comment-15958432
]
Chia-Ping Tsai commented on HBASE-17872:
bq. No need to add new patch. Just fix that on ur
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958297#comment-15958297
]
Anoop Sam John commented on HBASE-17872:
No need to add new patch. Just fix that on ur commit.
>
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958296#comment-15958296
]
Chia-Ping Tsai commented on HBASE-17872:
I will add the @visibileForTesting in next patch. Thanks
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958292#comment-15958292
]
ramkrishna.s.vasudevan commented on HBASE-17872:
Seeing 2nd patch. Looks good.
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958286#comment-15958286
]
Anoop Sam John commented on HBASE-17872:
disableUnsafe -> Pls add @VisibleForTesting.
> The
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958281#comment-15958281
]
ramkrishna.s.vasudevan commented on HBASE-17872:
+1.
> The MSLABImpl generates the
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958275#comment-15958275
]
Chia-Ping Tsai commented on HBASE-17872:
bq. Consider introducing trivial change in hbase-server
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957143#comment-15957143
]
Ted Yu commented on HBASE-17872:
lgtm
Consider introducing trivial change in hbase-server module to run
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957001#comment-15957001
]
Chia-Ping Tsai commented on HBASE-17872:
Will commit it tomorrow if no objection.
> The
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956816#comment-15956816
]
Hadoop QA commented on HBASE-17872:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956781#comment-15956781
]
Anoop Sam John commented on HBASE-17872:
LGTM
> The MSLABImpl generates the invaild cells when
31 matches
Mail list logo
