[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131095#comment-16131095 ] Hudson commented on HBASE-18231: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/]) HBASE-18231 Deprecate Admin#closeRegion*() commands in favor of (appy: rev de696cf6b653749c6bf105ef3d62d7a6c6923c57) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckTwoRS.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117577#comment-16117577 ] stack commented on HBASE-18231: --- Admin will be broken for a few reasons. I like your concern though @appy wondering about how it fails. Let's try it and see. Let fill in info in a while. > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113575#comment-16113575 ] Hudson commented on HBASE-18231: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3482 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3482/]) HBASE-18231 Deprecate Admin#closeRegion*() commands in favor of (appy: rev de696cf6b653749c6bf105ef3d62d7a6c6923c57) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckTwoRS.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113521#comment-16113521 ] Appy commented on HBASE-18231: -- Let's wait for verdict on removing/not-removing Admin#closeRegion functions. Then i'll put up patch for everything together. > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113259#comment-16113259 ] Chia-Ping Tsai commented on HBASE-18231: The AsyncAdmin an new feature introduced into 2.0+ only so AsyncAdmin#closeRegion can be removed. > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113234#comment-16113234 ] Appy commented on HBASE-18231: -- That'll break user clients. >From the "hbase 2.0 compatibility expectations" thread: bq. An hbase1 client can run against an hbase2 cluster but it will only be able to do DML (Get/Put/Scan, etc.). We do not allow being able to do admin ops using an hbase1 Admin client against an hbase2 cluster. So we certainly don't have to worry about compat, but am not sure what's the accepted way to fail. Is it fine to just remove the methods, because then the clients might crash? [~stack] > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[
https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112226#comment-16112226
]
Ted Yu commented on HBASE-18231:
For AsyncAdmin.java :
{code}
+ * @deprecated Since 2.0. Will be removed in 3.0. Use {@link
#unassign(byte[], boolean)} instead.
*/
CompletableFuture closeRegion(byte[] regionName,
Optional serverName);
{code}
Since 2.0 has not been released. The above method can be removed, right ?
> Deprecate and throw unsupported operation when Admin#closeRegion is called.
> ---
>
> Key: HBASE-18231
> URL: https://issues.apache.org/jira/browse/HBASE-18231
> Project: HBase
> Issue Type: Sub-task
> Components: Admin
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Appy
>Priority: Critical
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HBASE-18231.master.001.patch,
> HBASE-18231.master.002.patch, HBASE-18231.master.003.patch
>
>
> [~uagashe] tripped over this today. Admin#closeRegion which we used to use in
> branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign
> -- i.e. all cluster ops must go via the Master; no more going direct to
> RegionServer closing regions behind the Master's back.
> Review all Admin ops to see what else skirts Master and deprecate and throw
> unsupported if called.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111955#comment-16111955 ] Appy commented on HBASE-18231: -- That test is broken, marked '@Ignore' and needs to be fixed (HBASE-18425). So ignored it from scope of this jira. > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111941#comment-16111941 ] stack commented on HBASE-18231: --- [~appy] the test failure is not related? > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111835#comment-16111835 ] Appy commented on HBASE-18231: -- Thanks for the reviews [~stack] and [~syuanjiang]. Committing to master. > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[
https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109879#comment-16109879
]
Hadoop QA commented on HBASE-18231:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}156m 21s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}213m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterFailover |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18231 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879887/HBASE-18231.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 790a68cae13f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / a5db120 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7875/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7875/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109474#comment-16109474 ] Appy commented on HBASE-18231: -- Thanks for bring it up [~zghaobac]. Updated the patch and RB. > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch, HBASE-18231.master.003.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108444#comment-16108444 ] Guanghao Zhang commented on HBASE-18231: Do the async admin need the same change too? > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[
https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108399#comment-16108399
]
Hadoop QA commented on HBASE-18231:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
57s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}118m 0s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}177m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterFailover |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18231 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879763/HBASE-18231.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 63c000116c44 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / a5db120 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7863/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7863/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[
https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108391#comment-16108391
]
Hadoop QA commented on HBASE-18231:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 53s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
36s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}114m 24s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterFailover |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18231 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879760/HBASE-18231.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 19533f6e178e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / a5db120 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7862/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7862/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[ https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108360#comment-16108360 ] stack commented on HBASE-18231: --- Sweet. +1 [~appy] > Deprecate and throw unsupported operation when Admin#closeRegion is called. > --- > > Key: HBASE-18231 > URL: https://issues.apache.org/jira/browse/HBASE-18231 > Project: HBase > Issue Type: Sub-task > Components: Admin >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Appy >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18231.master.001.patch, > HBASE-18231.master.002.patch > > > [~uagashe] tripped over this today. Admin#closeRegion which we used to use in > branch-1 will cause damage in AMv2 cluster. Instead you need to call unassign > -- i.e. all cluster ops must go via the Master; no more going direct to > RegionServer closing regions behind the Master's back. > Review all Admin ops to see what else skirts Master and deprecate and throw > unsupported if called. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
