[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131137#comment-16131137 ] Hudson commented on HBASE-18566: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/]) HBASE-18566 [RSGROUP]Log the client IP/port of the rsgroup admin (tedyu: rev c6bf4d51928985517c438d1efcaefdeddc9ac5ef) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java * (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125395#comment-16125395 ] Hudson commented on HBASE-18566: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3529 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3529/]) HBASE-18566 [RSGROUP]Log the client IP/port of the rsgroup admin (tedyu: rev c6bf4d51928985517c438d1efcaefdeddc9ac5ef) * (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125333#comment-16125333 ] Hudson commented on HBASE-18566: FAILURE: Integrated in Jenkins build HBase-2.0 #326 (See [https://builds.apache.org/job/HBase-2.0/326/]) HBASE-18566 [RSGROUP]Log the client IP/port of the rsgroup admin (tedyu: rev de22fabed2682cace6c64ef566677437070e4950) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125244#comment-16125244 ] Guangxu Cheng commented on HBASE-18566: --- Thanks [~yuzhih...@gmail.com] for reviewing and committing.:) > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125205#comment-16125205 ] Guangxu Cheng commented on HBASE-18566: --- uhmm，I have updated the newest code on my computer and re-tested it again. v1 can be applied to branch-2 and master normally. :( > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125181#comment-16125181 ] Ted Yu commented on HBASE-18566: v1 doesn't apply to branch-2. Please upload patch for branch-2. > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125173#comment-16125173 ] Guangxu Cheng commented on HBASE-18566: --- Update v1 patch as [~yuzhih...@gmail.com] suggestions.Thanks > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-18566.patch, HBASE-18566.v1.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125163#comment-16125163 ] Guangxu Cheng commented on HBASE-18566: --- bq.Have you applied the patch and observed that there is no excessive logging (the new logs are at INFO level) ? I have applied the patch to our production cluster. For each operation of the rsgroup, it will print a line of logs, there is no excessive logging. > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-18566.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[
https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123131#comment-16123131
]
Ted Yu commented on HBASE-18566:
{code}
142 LOG.info(master.getClientIdAuditPrefix() + " get rsgroup info,
table="
{code}
Can you phrase the log this way: XX initiates rsgroup info retrieval ...
Have you applied the patch and observed that there is no excessive logging (the
new logs are at INFO level) ?
> [RSGROUP]Log the client IP/port of the rsgroup admin
>
>
> Key: HBASE-18566
> URL: https://issues.apache.org/jira/browse/HBASE-18566
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18566.patch
>
>
> It is necessary to log the client IP/port of the rsgroup admin command as
> discussion in HBASE-8754,so that we know who moved the servers from one group
> to another etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122778#comment-16122778 ] Guangxu Cheng commented on HBASE-18566: --- Upload the first patch for review.Thanks > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-18566.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18566) [RSGROUP]Log the client IP/port of the rsgroup admin
[ https://issues.apache.org/jira/browse/HBASE-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122753#comment-16122753 ] Guangxu Cheng commented on HBASE-18566: --- Upload the first patch for review. > [RSGROUP]Log the client IP/port of the rsgroup admin > > > Key: HBASE-18566 > URL: https://issues.apache.org/jira/browse/HBASE-18566 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-18566.patch > > > It is necessary to log the client IP/port of the rsgroup admin command as > discussion in HBASE-8754,so that we know who moved the servers from one group > to another etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
