[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214320#comment-16214320
]
Xiang Li commented on HBASE-18824:
--
Thanks very much [~jerryhe] for the suggestion!
> Add meaningful
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214319#comment-16214319
]
Xiang Li commented on HBASE-18824:
--
Thanks very much [~chia7712] for the suggestion and patience!
> Add
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214133#comment-16214133
]
Hudson commented on HBASE-18824:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3927 (See
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214086#comment-16214086
]
Chia-Ping Tsai commented on HBASE-18824:
Will commit it later
> Add meaningful comment to
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214057#comment-16214057
]
Hadoop QA commented on HBASE-18824:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214041#comment-16214041
]
Chia-Ping Tsai commented on HBASE-18824:
LGTM, Nice comment!
> Add meaningful comment to
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214032#comment-16214032
]
Xiang Li commented on HBASE-18824:
--
Hi [~chia7712], thanks for your comment and patience!
1. Regarding
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211185#comment-16211185
]
Chia-Ping Tsai commented on HBASE-18824:
{quote}
+ *c. When the count of existing cells
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211104#comment-16211104
]
Chia-Ping Tsai commented on HBASE-18824:
The exeption is caused by that the number of cells we
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211072#comment-16211072
]
Hadoop QA commented on HBASE-18824:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211069#comment-16211069
]
Xiang Li commented on HBASE-18824:
--
Uploaded patch 004, by adding the explanation for the condition when
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210490#comment-16210490
]
Xiang Li commented on HBASE-18824:
--
[~chia7712], thanks for your time for the review!
Regarding
bq.
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209466#comment-16209466
]
Chia-Ping Tsai commented on HBASE-18824:
bq. When the count of existing cells is equal to the
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209434#comment-16209434
]
Chia-Ping Tsai commented on HBASE-18824:
+1
> Add meaningful comment to
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209435#comment-16209435
]
Chia-Ping Tsai commented on HBASE-18824:
Will commit it later.
> Add meaningful comment to
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208838#comment-16208838
]
Chia-Ping Tsai commented on HBASE-18824:
What I mean is v2 patch need to be updated. greater ->
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208782#comment-16208782
]
Xiang Li commented on HBASE-18824:
--
[~chia7712], any comment to patch 002? 8-)
> Add meaningful comment
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208781#comment-16208781
]
Xiang Li commented on HBASE-18824:
--
Yes, I believe the reason why {{result.size() > count}} is an
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207806#comment-16207806
]
Chia-Ping Tsai commented on HBASE-18824:
bq. Are you talking about the following code in
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207715#comment-16207715
]
Xiang Li commented on HBASE-18824:
--
Hi [~chia7712],
regarding
bq. Region try to find enough PUT cells
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205297#comment-16205297
]
Hadoop QA commented on HBASE-18824:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205283#comment-16205283
]
Chia-Ping Tsai commented on HBASE-18824:
{quote}
When the size of Get's result is greater than
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205135#comment-16205135
]
Xiang Li commented on HBASE-18824:
--
[~chia7712], would you please review patch 002 at your most
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204170#comment-16204170
]
Chia-Ping Tsai commented on HBASE-18824:
bq. the code updates the timestamp to the latest
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201355#comment-16201355
]
Xiang Li commented on HBASE-18824:
--
[~chia7712], thanks for guide!
I read the code of
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178977#comment-16178977
]
Chia-Ping Tsai commented on HBASE-18824:
bq. the logic is the same: update the ts with
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178949#comment-16178949
]
Xiang Li commented on HBASE-18824:
--
[~chia7712], thanks for the review. It is addressed by patch 001.
If
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173342#comment-16173342
]
Chia-Ping Tsai commented on HBASE-18824:
Nice work. BTW, Could you also add comment about how
28 matches
Mail list logo
