[ 
https://issues.apache.org/jira/browse/HBASE-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225510#comment-16225510
 ] 

Jerry He commented on HBASE-19003:
----------------------------------

It looks good overall. 
The balancer's retainAssignment, randomAssignment and roundRobinAssignment all 
take a list of servers as parameter. 
We always call ServerManager.createDestinationServersList() to get the server 
list. This is a good list, with consideration of only online servers and 
avoiding the drainning servers.
The balancer's balanceCluster call has the draining servers removed from 
consideration to begin with.
Moreover, the assign phase will check the plan against the list obtained by 
ServerManager.createDestinationServersList(), which doubly make it unlikely
that a region is assigned to a wrong server.

> Make sure all balancer actions respect decommissioned server
> ------------------------------------------------------------
>
>                 Key: HBASE-19003
>                 URL: https://issues.apache.org/jira/browse/HBASE-19003
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jerry He
>             Fix For: 2.0.0-beta-1
>
>
> There have been questions raised in HBASE-10367 and other related JIRAs. We 
> want to make sure all aspects of the balancer respect the draining flag. We 
> will have a good look, and fix if any violation is found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to