[jira] [Commented] (HBASE-19069) Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
[ https://issues.apache.org/jira/browse/HBASE-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216688#comment-16216688 ] Hudson commented on HBASE-19069: FAILURE: Integrated in Jenkins build HBase-2.0 #740 (See [https://builds.apache.org/job/HBase-2.0/740/]) HBASE-19069 Do not wrap the original CompactionLifeCycleTracker when (zhangduo: rev a6f89f029a78a37eb84e4908b9975118e3050603) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionLifeCycleTracker.java > Do not wrap the original CompactionLifeCycleTracker when calling CP hooks > - > > Key: HBASE-19069 > URL: https://issues.apache.org/jira/browse/HBASE-19069 > Project: HBase > Issue Type: Sub-task > Components: Compaction, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19069.patch, HBASE-19069.patch > > > My fault... > The UT added in HBASE-18989 does not follow the new rule so the CP is not > loaded actually... When fixed the UT fails... > The reason is that I use a wrapped CompactionLifeCycleTracker for > implementing CompactionLifeCycleTracker. Obviously this is not the correct > approach as we need to pass the original one to CP hooks... > Let me fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19069) Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
[ https://issues.apache.org/jira/browse/HBASE-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216675#comment-16216675 ] Hudson commented on HBASE-19069: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3940 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3940/]) HBASE-19069 Do not wrap the original CompactionLifeCycleTracker when (zhangduo: rev 37b29e909defecdc580112ce6cd306710d13e9e2) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionLifeCycleTracker.java > Do not wrap the original CompactionLifeCycleTracker when calling CP hooks > - > > Key: HBASE-19069 > URL: https://issues.apache.org/jira/browse/HBASE-19069 > Project: HBase > Issue Type: Sub-task > Components: Compaction, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19069.patch, HBASE-19069.patch > > > My fault... > The UT added in HBASE-18989 does not follow the new rule so the CP is not > loaded actually... When fixed the UT fails... > The reason is that I use a wrapped CompactionLifeCycleTracker for > implementing CompactionLifeCycleTracker. Obviously this is not the correct > approach as we need to pass the original one to CP hooks... > Let me fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19069) Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
[ https://issues.apache.org/jira/browse/HBASE-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216212#comment-16216212 ] Duo Zhang commented on HBASE-19069: --- Let me finish this. Thanks [~stack] for reviewing. > Do not wrap the original CompactionLifeCycleTracker when calling CP hooks > - > > Key: HBASE-19069 > URL: https://issues.apache.org/jira/browse/HBASE-19069 > Project: HBase > Issue Type: Sub-task > Components: Compaction, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19069.patch, HBASE-19069.patch > > > My fault... > The UT added in HBASE-18989 does not follow the new rule so the CP is not > loaded actually... When fixed the UT fails... > The reason is that I use a wrapped CompactionLifeCycleTracker for > implementing CompactionLifeCycleTracker. Obviously this is not the correct > approach as we need to pass the original one to CP hooks... > Let me fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19069) Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
[ https://issues.apache.org/jira/browse/HBASE-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215890#comment-16215890 ] stack commented on HBASE-19069: --- Skimmed. LGTM. > Do not wrap the original CompactionLifeCycleTracker when calling CP hooks > - > > Key: HBASE-19069 > URL: https://issues.apache.org/jira/browse/HBASE-19069 > Project: HBase > Issue Type: Sub-task > Components: Compaction, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19069.patch, HBASE-19069.patch > > > My fault... > The UT added in HBASE-18989 does not follow the new rule so the CP is not > loaded actually... When fixed the UT fails... > The reason is that I use a wrapped CompactionLifeCycleTracker for > implementing CompactionLifeCycleTracker. Obviously this is not the correct > approach as we need to pass the original one to CP hooks... > Let me fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19069) Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
[
https://issues.apache.org/jira/browse/HBASE-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215411#comment-16215411
]
Hadoop QA commented on HBASE-19069:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
33s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
55s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
41m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}105m
7s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}184m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:cb5c477 |
| JIRA Issue | HBASE-19069 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893528/HBASE-19069.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux adae9856d033 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 880b26d |
| Default Java | 1.8.0_141 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9351/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9351/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
>
[jira] [Commented] (HBASE-19069) Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
[
https://issues.apache.org/jira/browse/HBASE-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215136#comment-16215136
]
Hadoop QA commented on HBASE-19069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 6m
11s{color} | {color:red} Docker failed to build yetus/hbase:cb5c477. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19069 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893527/HBASE-19069.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9350/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Do not wrap the original CompactionLifeCycleTracker when calling CP hooks
> -
>
> Key: HBASE-19069
> URL: https://issues.apache.org/jira/browse/HBASE-19069
> Project: HBase
> Issue Type: Sub-task
> Components: Compaction, Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19069.patch
>
>
> My fault...
> The UT added in HBASE-18989 does not follow the new rule so the CP is not
> loaded actually... When fixed the UT fails...
> The reason is that I use a wrapped CompactionLifeCycleTracker for
> implementing CompactionLifeCycleTracker. Obviously this is not the correct
> approach as we need to pass the original one to CP hooks...
> Let me fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
