[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408094#comment-16408094 ] Chia-Ping Tsai commented on HBASE-19552: see HBASE-20246 > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.ADDENDUM.patch, > HBASE-19552.branch-2.addendum.patch.patch, HBASE-19552.patch, > HBASE-19552.v2.patch, HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, > HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[
https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408091#comment-16408091
]
Chia-Ping Tsai commented on HBASE-19552:
{quote}since this jira already went into a release, let's please fix this in a
follow up JIRA.
{quote}
ok
> update hbase to use new thirdparty libs
> ---
>
> Key: HBASE-19552
> URL: https://issues.apache.org/jira/browse/HBASE-19552
> Project: HBase
> Issue Type: Task
> Components: dependencies, thirdparty
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19552.ADDENDUM.patch,
> HBASE-19552.branch-2.addendum.patch.patch, HBASE-19552.patch,
> HBASE-19552.v2.patch, HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch,
> HBASE-19552.v4.FULL.patch
>
>
> When we release hbase-thirdparty next release, we will need to update our
> code for the packaging change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408087#comment-16408087 ] Sean Busbey commented on HBASE-19552: - since this jira already went into a release, let's please fix this in a follow up JIRA. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.ADDENDUM.patch, > HBASE-19552.branch-2.addendum.patch.patch, HBASE-19552.patch, > HBASE-19552.v2.patch, HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, > HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407984#comment-16407984 ] Mike Drob commented on HBASE-19552: --- What, where? On a phone note but that seems very wrong > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.ADDENDUM.patch, > HBASE-19552.branch-2.addendum.patch.patch, HBASE-19552.patch, > HBASE-19552.v2.patch, HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, > HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305900#comment-16305900 ] Hudson commented on HBASE-19552: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4303 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4303/]) HBASE-19552 ADDENDUM fix shaded lib check (mdrob: rev b3f353cd3ce6bd1ad5ed8c1e9dc390a33d62ce0e) * (edit) hbase-shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.ADDENDUM.patch, HBASE-19552.patch, > HBASE-19552.v2.patch, HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, > HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305791#comment-16305791 ] stack commented on HBASE-19552: --- +1 Makes sense. Thanks [~mdrob] > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.ADDENDUM.patch, HBASE-19552.patch, > HBASE-19552.v2.patch, HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, > HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305756#comment-16305756 ] Hudson commented on HBASE-19552: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4302 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4302/]) HBASE-19552 Update hbase-thirdparty version (mdrob: rev ea7d5fc88454cc8d623d837e2d8975643e354bda) * (edit) bin/hbase * (edit) hbase-mapreduce/pom.xml * (edit) src/main/asciidoc/_chapters/developer.adoc * (edit) hbase-protocol-shaded/pom.xml * (edit) hbase-server/pom.xml * (edit) pom.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml * (edit) hbase-spark/pom.xml HBASE-19552 find-and-replace thirdparty offset (mdrob: rev c3b4f788b16ac4e0e8cfd319f495308ba4d158f5) * (edit) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/ExampleMasterObserverWithMetrics.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorSegmentsIterator.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * (edit) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDeleteRestore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterAnnotationReadingPriorityFunction.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionPolicy.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/AES.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/CryptoAESWrapHandler.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLazyDataBlockDecompression.java * (edit) hbase-spark/src/test/java/org/apache/hadoop/hbase/spark/TestJavaHBaseContext.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/locking/TestLockProcedure.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/ShadedAccessControlUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MetricsCoprocessor.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/util/MetricSampleQuantiles.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdminRequestRetryingCaller.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcUtils.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestTableQuotaViolationStore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/ExportUtils.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/SimpleProcedureScheduler.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestAcidGuaranteesWithNoInMemCompaction.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpointNoMaster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/LoadBalancerPerformanceEvaluation.java * (edit)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305637#comment-16305637 ] Mike Drob commented on HBASE-19552: --- Thanks for reviews all, pushed to branch-2 and master. If there are issues that come out of this please file JIRAs and let me know! > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305616#comment-16305616 ] Chia-Ping Tsai commented on HBASE-19552: bq. Your argument is that an enforced import-order makes for less change over time? yep bq. As long as the order is easy to enforce, simple alphabetization, I can buy that. Currently, all rule for imports can be implemented by the checkstyle, and it is vary simple I believe. Also, [~Jan Hentschel] is working to fix all checkstyle warnings for our hbase (see HBASE-12521). It is a hard and great job. That is why I prefer to keep the failOnViolatio. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305608#comment-16305608 ] stack commented on HBASE-19552: --- [~chia7712] Your argument is that an enforced import-order makes for less change over time? As long as the order is easy to enforce, simple alphabetization, I can buy that. Thanks. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305605#comment-16305605 ] Chia-Ping Tsai commented on HBASE-19552: bq. Alphabetize in a future issue? This may be not necessary. bq. failOnViolation of import order is over-the-top IMO. We should undo it? I don't thinks so since it is also ugly that we make many changes for the import reorder. We should make it a rule to follow our code style. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305599#comment-16305599 ] stack commented on HBASE-19552: --- I'm +1 on commit too. Alphabetize in a future issue? failOnViolation of import order is over-the-top IMO. We should undo it? > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305597#comment-16305597 ] Chia-Ping Tsai commented on HBASE-19552: It makes sense to do the min changes for our hbase. :) +1 on BASE > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305519#comment-16305519 ] Mike Drob commented on HBASE-19552: --- Putting `thirdparty` before `shaded` let me get away with not changing the import order on anything, which is why it was my preferred solution. Agree that it's kind of ugly, but would prefer to alphabetize in a future commit? `failOnViolation` is the only reason I ended up caring about this. :) > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[
https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305061#comment-16305061
]
Chia-Ping Tsai commented on HBASE-19552:
bq. I updated the checkstyle import order rule, WDYT?
Perhaps {{org.apache.hbase.thirdparty}} should be placed at end? Just sort the
groups alphabetically.
The {{failOnViolation}} is enable in some modules so checking the imports order
is necessary now...
> update hbase to use new thirdparty libs
> ---
>
> Key: HBASE-19552
> URL: https://issues.apache.org/jira/browse/HBASE-19552
> Project: HBase
> Issue Type: Task
> Components: dependencies, thirdparty
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19552.patch, HBASE-19552.v2.patch,
> HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch
>
>
> When we release hbase-thirdparty next release, we will need to update our
> code for the packaging change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304853#comment-16304853 ] Mike Drob commented on HBASE-19552: --- Yep, patch needs a rebase again due to... idk. something. This one will be impossible to keep a patch healthy on JIRA for any length of time, and very difficult to get a QA run in therefore. I'll leave the attached patches here for review a bit longer, but I'm not going to continue uploading new ones unless the base version changes. Too sisyphean for me. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[
https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304851#comment-16304851
]
Hadoop QA commented on HBASE-19552:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-19552 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19552 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903841/HBASE-19552.v4.FULL.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10757/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> update hbase to use new thirdparty libs
> ---
>
> Key: HBASE-19552
> URL: https://issues.apache.org/jira/browse/HBASE-19552
> Project: HBase
> Issue Type: Task
> Components: dependencies, thirdparty
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19552.patch, HBASE-19552.v2.patch,
> HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch
>
>
> When we release hbase-thirdparty next release, we will need to update our
> code for the packaging change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304849#comment-16304849 ] stack commented on HBASE-19552: --- Reviewed BASE. its great. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch, HBASE-19552.v4.BASE.patch, HBASE-19552.v4.FULL.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[
https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304831#comment-16304831
]
Hadoop QA commented on HBASE-19552:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
3s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
7s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
35s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
1s{color} | {color:red} The patch generated 5 new + 40 unchanged - 5 fixed = 45
total (was 45) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m
2s{color} | {color:red} patch has 283 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
47s{color} | {color:red} The patch causes 283 errors with Hadoop v2.6.5.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
29s{color} | {color:red} The patch causes 283 errors with Hadoop v2.7.4.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
13s{color} | {color:red} The patch causes 283 errors with Hadoop v3.0.0.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
25s{color} | {color:red} hbase-server generated 100 new + 0 unchanged - 2 fixed
= 100 total (was 2) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
13s{color} | {color:red} hbase-mapreduce generated 30 new + 0 unchanged - 0
fixed = 30 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m
39s{color} | {color:red} root generated 496 new + 23 unchanged - 7 fixed = 519
total (was 30) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 56s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19552 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903836/HBASE-19552.v4.BASE.patch
|
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit
xml shadedjars hadoopcheck compile
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304789#comment-16304789 ] Jan Hentschel commented on HBASE-19552: --- Not sure. I use the one from [~appy] from HBASE-19262. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304783#comment-16304783 ] Mike Drob commented on HBASE-19552: --- Cool, I found the IntelliJ options now, and see that they can be applied to the whole project, and specifically only to the changed files. Is the latest layout committed to dev-support? Want to make sure that I have the right one before going through with all of this. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304706#comment-16304706 ] Jan Hentschel commented on HBASE-19552: --- [~mdrob] Not sure if there's IDE support for this one if you have the appropriate import layout in place. If you're on IntelliJ, maybe [this|https://stackoverflow.com/a/8609200/3233464] could help. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304699#comment-16304699 ] Mike Drob commented on HBASE-19552: --- [~Jan Hentschel] - the code changes that I'm going through here cause a lot of problems for checkstyle import order - do you have any suggestions on how to clean that up post-sed with an automated tool? It would be absolutely miserable to have to go through and fix each file individually. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch, > HBASE-19552.v3.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297487#comment-16297487 ] Jerry He commented on HBASE-19552: -- Glanced through. Looks good. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Attachments: HBASE-19552.patch, HBASE-19552.v2.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19552) update hbase to use new thirdparty libs
[ https://issues.apache.org/jira/browse/HBASE-19552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295688#comment-16295688 ] Mike Drob commented on HBASE-19552: --- Ugh, 770kB, this is not ideal. > update hbase to use new thirdparty libs > --- > > Key: HBASE-19552 > URL: https://issues.apache.org/jira/browse/HBASE-19552 > Project: HBase > Issue Type: Task > Components: dependencies, thirdparty >Reporter: Mike Drob >Assignee: Mike Drob > Attachments: HBASE-19552.patch > > > When we release hbase-thirdparty next release, we will need to update our > code for the packaging change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
