[jira] [Commented] (HBASE-19566) Fix Checkstyle errors in hbase-client-project
[ https://issues.apache.org/jira/browse/HBASE-19566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321627#comment-16321627 ] Appy commented on HBASE-19566: -- Oh nvm, figured it, to avoid new ones from getting added. > Fix Checkstyle errors in hbase-client-project > - > > Key: HBASE-19566 > URL: https://issues.apache.org/jira/browse/HBASE-19566 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19566.master.001.patch > > > Fix the remaining Checkstyle errors in the *hbase-client-project* module and > enable Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19566) Fix Checkstyle errors in hbase-client-project
[
https://issues.apache.org/jira/browse/HBASE-19566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321626#comment-16321626
]
Appy commented on HBASE-19566:
--
Why do we need this? It's not needed for modules like hbase-server.
{noformat}
81
82 org.apache.maven.plugins
83 maven-checkstyle-plugin
84
85
86 checkstyle
87 validate
88
89check
90
91
92true
93
94
95
96
{noformat}
> Fix Checkstyle errors in hbase-client-project
> -
>
> Key: HBASE-19566
> URL: https://issues.apache.org/jira/browse/HBASE-19566
> Project: HBase
> Issue Type: Sub-task
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-19566.master.001.patch
>
>
> Fix the remaining Checkstyle errors in the *hbase-client-project* module and
> enable Checkstyle to fail on violations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19566) Fix Checkstyle errors in hbase-client-project
[ https://issues.apache.org/jira/browse/HBASE-19566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299540#comment-16299540 ] Hudson commented on HBASE-19566: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4263 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4263/]) HBASE-19566 Fixed Checkstyle errors in hbase-archetypes and enabled (jan.hentschel: rev d95cf54ba644b18e35a4d88334c674df83e01c7f) * (edit) hbase-archetypes/hbase-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/client/TestHelloHBase.java * (edit) hbase-archetypes/hbase-shaded-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/shaded_client/TestHelloHBase.java * (edit) hbase-archetypes/pom.xml > Fix Checkstyle errors in hbase-client-project > - > > Key: HBASE-19566 > URL: https://issues.apache.org/jira/browse/HBASE-19566 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19566.master.001.patch > > > Fix the remaining Checkstyle errors in the *hbase-client-project* module and > enable Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19566) Fix Checkstyle errors in hbase-client-project
[ https://issues.apache.org/jira/browse/HBASE-19566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299067#comment-16299067 ] Appy commented on HBASE-19566: -- +1 > Fix Checkstyle errors in hbase-client-project > - > > Key: HBASE-19566 > URL: https://issues.apache.org/jira/browse/HBASE-19566 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19566.master.001.patch > > > Fix the remaining Checkstyle errors in the *hbase-client-project* module and > enable Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19566) Fix Checkstyle errors in hbase-client-project
[
https://issues.apache.org/jira/browse/HBASE-19566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298822#comment-16298822
]
Hadoop QA commented on HBASE-19566:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
57s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} hbase-archetypes: The patch generated 0 new + 0
unchanged - 18 fixed = 0 total (was 18) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} hbase-archetypes/hbase-client-project: The patch
generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} hbase-archetypes/hbase-shaded-client-project: The
patch generated 0 new + 0 unchanged - 9 fixed = 0 total (was 9) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
42s{color} | {color:green} hbase-archetypes in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-client-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-shaded-client-project in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 18s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce
[jira] [Commented] (HBASE-19566) Fix Checkstyle errors in hbase-client-project
[ https://issues.apache.org/jira/browse/HBASE-19566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298754#comment-16298754 ] Jan Hentschel commented on HBASE-19566: --- Did it for the complete archetypes module instead to not include Checkstyle in the POM of the individual archetypes. > Fix Checkstyle errors in hbase-client-project > - > > Key: HBASE-19566 > URL: https://issues.apache.org/jira/browse/HBASE-19566 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19566.master.001.patch > > > Fix the remaining Checkstyle errors in the *hbase-client-project* module and > enable Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
