[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824016#comment-16824016
]
Hudson commented on HBASE-19682:
Results for branch master
[build #954 on
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673074#comment-16673074
]
Hudson commented on HBASE-19682:
Results for branch master
[build #581 on
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672433#comment-16672433
]
Hudson commented on HBASE-19682:
Results for branch branch-2
[build #1477 on
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655568#comment-16655568
]
Hadoop QA commented on HBASE-19682:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654664#comment-16654664
]
Sean Busbey commented on HBASE-19682:
-
Thanks for re-running the qabot. it looks like my rerun of v5
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654657#comment-16654657
]
Hadoop QA commented on HBASE-19682:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654549#comment-16654549
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539148#comment-16539148
]
BELUGA BEHR commented on HBASE-19682:
-
Please accept this submission to the project.
> Use
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516148#comment-16516148
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396569#comment-16396569
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396462#comment-16396462
]
Mike Drob commented on HBASE-19682:
---
V3 looks good too.
> Use Collections.emptyList() For Empty List
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396458#comment-16396458
]
Mike Drob commented on HBASE-19682:
---
Patch looks good to me but I haven't looked at the older ones to
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318557#comment-16318557
]
BELUGA BEHR commented on HBASE-19682:
-
[~appy] In regards to changing the API, I had considered that,
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317967#comment-16317967
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317690#comment-16317690
]
Appy commented on HBASE-19682:
--
I see that when return type is List, there can be lot of gotchas and there's
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317539#comment-16317539
]
BELUGA BEHR commented on HBASE-19682:
-
[~appy] I would simply point out that the List Add method is
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317349#comment-16317349
]
Appy commented on HBASE-19682:
--
The test failures may indeed be not related since no common failures between
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317001#comment-16317001
]
BELUGA BEHR commented on HBASE-19682:
-
[~appy] :)
> Use Collections.emptyList() For Empty List
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309151#comment-16309151
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309008#comment-16309008
]
BELUGA BEHR commented on HBASE-19682:
-
I posted one more patch to fix the silly check-style. Sorry
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308902#comment-16308902
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308861#comment-16308861
]
Appy commented on HBASE-19682:
--
Yeah, i was wondering that this might fail some tests because of immutable
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308624#comment-16308624
]
Appy commented on HBASE-19682:
--
patch1: Missing 'return' keyword in two places. Rest looks good.
> Use
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308149#comment-16308149
]
BELUGA BEHR commented on HBASE-19682:
-
[~chia7712]
WALSplitter [HBASE-19613]
HStore [HBASE-19675]
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307671#comment-16307671
]
Chia-Ping Tsai commented on HBASE-19682:
WALSplitter#1680
Canary#1243
BaseLoadBalancer#1555
[
https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307576#comment-16307576
]
Hadoop QA commented on HBASE-19682:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
26 matches
Mail list logo