[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316317#comment-16316317
]
Hudson commented on HBASE-19684:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4363 (See
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316039#comment-16316039
]
Hudson commented on HBASE-19684:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #331 (See
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316038#comment-16316038
]
Hudson commented on HBASE-19684:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1055 (See
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315923#comment-16315923
]
Duo Zhang commented on HBASE-19684:
---
Can not push to asf git...
{noformat}
fatal: unable to access
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315861#comment-16315861
]
Duo Zhang commented on HBASE-19684:
---
+1 on using the simple '+' operator. Will commit later if no
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313313#comment-16313313
]
BELUGA BEHR commented on HBASE-19684:
-
[~appy] and [~mdrob] I think we have put the bow on this
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310410#comment-16310410
]
Mike Drob commented on HBASE-19684:
---
Yea, looking at the bytecode we can confirm that concat operator
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310405#comment-16310405
]
BELUGA BEHR commented on HBASE-19684:
-
I'd probably just keep for the current patch as it is most
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310399#comment-16310399
]
BELUGA BEHR commented on HBASE-19684:
-
Just let me know which version you would like... or go ahead
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310390#comment-16310390
]
BELUGA BEHR commented on HBASE-19684:
-
[~mdrob] If you want to play that game... HA! :)
{code}
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309134#comment-16309134
]
Hadoop QA commented on HBASE-19684:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309055#comment-16309055
]
Mike Drob commented on HBASE-19684:
---
FWIW, looks like StringBuilder may be the most performant
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309031#comment-16309031
]
Mike Drob commented on HBASE-19684:
---
My -1 was for v1 of the patch based on the dubious benchmarking
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309026#comment-16309026
]
BELUGA BEHR commented on HBASE-19684:
-
[~mdrob] The current implementation is:
{code}
return
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309025#comment-16309025
]
Mike Drob commented on HBASE-19684:
---
-1 to this patch as is.
We need to either improve performance or
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309014#comment-16309014
]
BELUGA BEHR commented on HBASE-19684:
-
[~appy] Only special kind of people like you and I would
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309013#comment-16309013
]
Duo Zhang commented on HBASE-19684:
---
https://stackoverflow.com/a/46485284
This answer shows that '+'
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309012#comment-16309012
]
Appy commented on HBASE-19684:
--
I would also admit that at this point, the sole purpose of doing the
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309010#comment-16309010
]
BELUGA BEHR commented on HBASE-19684:
-
[~appy] "c" is an ArrayList that is pre-allocated with a 100K
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309004#comment-16309004
]
Appy commented on HBASE-19684:
--
Also, for correctness purpose, maybe you should use a new String c
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309000#comment-16309000
]
BELUGA BEHR commented on HBASE-19684:
-
[~Apache9] There isn't really, but this patch is already here
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308973#comment-16308973
]
Duo Zhang commented on HBASE-19684:
---
Could you please run a micro benchmark using jmh? A slow
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308832#comment-16308832
]
BELUGA BEHR commented on HBASE-19684:
-
[~appy] All I'm doing is creating a list of 100K string with
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308507#comment-16308507
]
Appy commented on HBASE-19684:
--
i like the way of reasoning! Please add that nice testing/finding of your to
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308291#comment-16308291
]
Hadoop QA commented on HBASE-19684:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308086#comment-16308086
]
BELUGA BEHR commented on HBASE-19684:
-
[~Apache9] Thanks for the review. :)
While I admit that it is
[
https://issues.apache.org/jira/browse/HBASE-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307586#comment-16307586
]
Duo Zhang commented on HBASE-19684:
---
Will it be more faster just with hfileName + "_" + offset? It will
27 matches
Mail list logo
