[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393575#comment-16393575 ] Hudson commented on HBASE-19711: Results for branch branch-2 [build #465 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/465/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/465//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/465//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/465//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > TestReplicationAdmin.testConcurrentPeerOperations hangs > --- > > Key: HBASE-19711 > URL: https://issues.apache.org/jira/browse/HBASE-19711 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.1.0 > > Attachments: HBASE-19711.HBASE-19397.001.patch, > HBASE-19711.HBASE-19397.002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317785#comment-16317785 ] Hudson commented on HBASE-19711: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4367 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4367/]) HBASE-19711 TestReplicationAdmin.testConcurrentPeerOperations hangs (zhangduo: rev 2d5267331e97f18cc7ac52b1c01d6ed54d721ba8) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java > TestReplicationAdmin.testConcurrentPeerOperations hangs > --- > > Key: HBASE-19711 > URL: https://issues.apache.org/jira/browse/HBASE-19711 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0 > > Attachments: HBASE-19711.HBASE-19397.001.patch, > HBASE-19711.HBASE-19397.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313069#comment-16313069 ] Duo Zhang commented on HBASE-19711: --- Will commit shortly. > TestReplicationAdmin.testConcurrentPeerOperations hangs > --- > > Key: HBASE-19711 > URL: https://issues.apache.org/jira/browse/HBASE-19711 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19711.HBASE-19397.001.patch, > HBASE-19711.HBASE-19397.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313057#comment-16313057 ] Hadoop QA commented on HBASE-19711: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} HBASE-19397 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 24s{color} | {color:green} HBASE-19397 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s{color} | {color:green} HBASE-19397 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 8s{color} | {color:green} HBASE-19397 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m 31s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} HBASE-19397 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 38s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 19m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}118m 27s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}159m 12s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19711 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12904767/HBASE-19711.HBASE-19397.002.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8327524d4de4 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | HBASE-19397 / be2403eb05 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/10896/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10896/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10896/console | | Powered by | Apache Yetus 0.6.0
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312908#comment-16312908 ] Hadoop QA commented on HBASE-19711: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 54s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} HBASE-19397 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 42s{color} | {color:green} HBASE-19397 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} HBASE-19397 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 6s{color} | {color:green} HBASE-19397 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 48s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} HBASE-19397 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 40s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 19m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}130m 10s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}170m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19711 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12904740/HBASE-19711.HBASE-19397.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 00c39f73b9bf 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | HBASE-19397 / be2403eb05 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/10894/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10894/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output |
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312779#comment-16312779 ] Duo Zhang commented on HBASE-19711: --- {quote} tryCleanupPeerQueue? {quote} +1. > TestReplicationAdmin.testConcurrentPeerOperations hangs > --- > > Key: HBASE-19711 > URL: https://issues.apache.org/jira/browse/HBASE-19711 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19711.HBASE-19397.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312726#comment-16312726 ] Guanghao Zhang commented on HBASE-19711: tryCleanupPeerQueue? As we will move it from peerRunQueue, too. bq. always call it when a PeerProcedureInterface is finished Sounds good. Let me attach a new patch. > TestReplicationAdmin.testConcurrentPeerOperations hangs > --- > > Key: HBASE-19711 > URL: https://issues.apache.org/jira/browse/HBASE-19711 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19711.HBASE-19397.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19711) TestReplicationAdmin.testConcurrentPeerOperations hangs
[ https://issues.apache.org/jira/browse/HBASE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312642#comment-16312642 ] Duo Zhang commented on HBASE-19711: --- I think peer related operations are rare, so let's name it as tryRemovePeerQueue, and always call it when a PeerProcedureInterface is finished, not only for the procedure which operation type is REMOVE? > TestReplicationAdmin.testConcurrentPeerOperations hangs > --- > > Key: HBASE-19711 > URL: https://issues.apache.org/jira/browse/HBASE-19711 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19711.HBASE-19397.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)