[jira] [Commented] (HBASE-19861) Avoid using RPCs when querying table infos for master status pages
[ https://issues.apache.org/jira/browse/HBASE-19861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516685#comment-16516685 ] Guanghao Zhang commented on HBASE-19861: bq. Is this behaviour intentional? Yes. backup master show nothing about tables. bq. I think we should fall back to rpc based listing in case of backup master and can have this improvement in case of active master. The backup master may use a seperate UI based on rpc. No need active master fall back to rpc. > Avoid using RPCs when querying table infos for master status pages > -- > > Key: HBASE-19861 > URL: https://issues.apache.org/jira/browse/HBASE-19861 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Fix For: 2.0.0-beta-2, 2.0.0 > > Attachments: 19861.4.patch, HBASE-19861.v1.patch, > HBASE-19861.v3.patch, HBASE-19861.v4.patch, errorMsgExample.png > > > When querying table information for master status pages, currently method is > using admin interfaces. For example, when list user tables, codes are as > follows. > Connection connection = master.getConnection(); > Admin admin = connection.getAdmin(); > try { > tables = admin.listTables(); > } finally { > admin.close(); > } > But actually, we can get all user tables from master's memory. > Using admin interfaces means using RPCs, which has a low efficiency. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19861) Avoid using RPCs when querying table infos for master status pages
[ https://issues.apache.org/jira/browse/HBASE-19861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515366#comment-16515366 ] Nihal Jain commented on HBASE-19861: Hi, now the backup master UI does not list any user tables. Is this behaviour intentional? > Avoid using RPCs when querying table infos for master status pages > -- > > Key: HBASE-19861 > URL: https://issues.apache.org/jira/browse/HBASE-19861 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Fix For: 2.0.0-beta-2, 2.0.0 > > Attachments: 19861.4.patch, HBASE-19861.v1.patch, > HBASE-19861.v3.patch, HBASE-19861.v4.patch, errorMsgExample.png > > > When querying table information for master status pages, currently method is > using admin interfaces. For example, when list user tables, codes are as > follows. > Connection connection = master.getConnection(); > Admin admin = connection.getAdmin(); > try { > tables = admin.listTables(); > } finally { > admin.close(); > } > But actually, we can get all user tables from master's memory. > Using admin interfaces means using RPCs, which has a low efficiency. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19861) Avoid using RPCs when querying table infos for master status pages
[ https://issues.apache.org/jira/browse/HBASE-19861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341787#comment-16341787 ] Hudson commented on HBASE-19861: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4473 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4473/]) HBASE-19861 - Avoid using RPCs when querying table infos for master (tedyu: rev 94a1c051ba64bf490b2cc65e5b813176f1d0bb45) * (edit) hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp * (edit) hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon > Avoid using RPCs when querying table infos for master status pages > -- > > Key: HBASE-19861 > URL: https://issues.apache.org/jira/browse/HBASE-19861 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 19861.4.patch, HBASE-19861.v1.patch, > HBASE-19861.v3.patch, HBASE-19861.v4.patch, errorMsgExample.png > > > When querying table information for master status pages, currently method is > using admin interfaces. For example, when list user tables, codes are as > follows. > Connection connection = master.getConnection(); > Admin admin = connection.getAdmin(); > try { > tables = admin.listTables(); > } finally { > admin.close(); > } > But actually, we can get all user tables from master's memory. > Using admin interfaces means using RPCs, which has a low efficiency. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19861) Avoid using RPCs when querying table infos for master status pages
[ https://issues.apache.org/jira/browse/HBASE-19861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341149#comment-16341149 ] Hadoop QA commented on HBASE-19861: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 4s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 50s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}117m 34s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19861 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12907873/19861.4.patch | | Optional Tests | asflicense javac javadoc unit | | uname | Linux 6879856dd2f3 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 39b912aae9 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11202/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11202/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11202/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > Avoid using RPCs when querying table infos for master status pages > -- > > Key: HBASE-19861 > URL: https://issues.apache.org/jira/browse/HBASE-19861 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: 19861.4.patch, HBASE-19861.v1.patch, > HBASE-19861.v3.patch, HBASE-19861.v4.patch, errorMsgExample.png > > > When querying table information for master status pages, currently method is > using admin interfaces. For example, when list user tables, codes are as > follows. > Connection connection = master.getConnection(); > Admin admin = connection.getAdmin(); > try { > tables = admin.listTables(); > } finally { > admin.close(); > } > But actually, we can get all user tables from master's memory. > Using admin interfaces means using RPCs, which has a low efficiency. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)