[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732500#comment-16732500
]
Josh Elser commented on HBASE-19863:
{quote}
Looks back on this... Isn't it cheaper to just detect
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720909#comment-16720909
]
Lars Hofhansl commented on HBASE-19863:
---
Looks back on this... Isn't it cheaper to just detect the
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381333#comment-16381333
]
Hudson commented on HBASE-19863:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4667 (See
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380802#comment-16380802
]
Josh Elser commented on HBASE-19863:
{quote}
Was: a method that had
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380788#comment-16380788
]
Sergey Soldatov commented on HBASE-19863:
-
[~elserj] well, my changes are quite simple.
Was: a
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380738#comment-16380738
]
Josh Elser commented on HBASE-19863:
It does look like (at least in branch-1.4) that not all
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380728#comment-16380728
]
Sergey Soldatov commented on HBASE-19863:
-
[~ram_krish] actually we were setting it to none by
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378283#comment-16378283
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378031#comment-16378031
]
ramkrishna.s.vasudevan commented on HBASE-19863:
LGTM. Just a question
{code}
public
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378023#comment-16378023
]
Ted Yu commented on HBASE-19863:
[~ram_krish]:
Do you want to take another look ?
>
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378015#comment-16378015
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377738#comment-16377738
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377500#comment-16377500
]
Sergey Soldatov commented on HBASE-19863:
-
[~yuzhih...@gmail.com] addressed your comments in v5.
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376447#comment-16376447
]
Chia-Ping Tsai commented on HBASE-19863:
[~sergey.soldatov] Would you please prepare the patch
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375290#comment-16375290
]
Chia-Ping Tsai commented on HBASE-19863:
+1
> java.lang.IllegalStateException: isDelete failed
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375278#comment-16375278
]
Ted Yu commented on HBASE-19863:
[~chia7712] [~ram_krish]:
Mind taking another look ?
>
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375186#comment-16375186
]
Hadoop QA commented on HBASE-19863:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375109#comment-16375109
]
Ted Yu commented on HBASE-19863:
Looks good overall.
{code}
+ @BeforeClass public static void
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375057#comment-16375057
]
Sergey Soldatov commented on HBASE-19863:
-
[~yuzhih...@gmail.com] Ough. Didn't notice that.
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375027#comment-16375027
]
Ted Yu commented on HBASE-19863:
The error was on branch-2 v3, not v4.
You can re-attach v4 patch one
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375017#comment-16375017
]
Sergey Soldatov commented on HBASE-19863:
-
That's exactly what I have in the patch
{noformat}
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374994#comment-16374994
]
Ted Yu commented on HBASE-19863:
Please include snippet similar to the following:
{code}
@ClassRule
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374898#comment-16374898
]
Sergey Soldatov commented on HBASE-19863:
-
[~yuzhih...@gmail.com] that looks like a flaky test
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374800#comment-16374800
]
Ted Yu commented on HBASE-19863:
>From the above QA report:
{code}
[ERROR]
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372607#comment-16372607
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367500#comment-16367500
]
Chia-Ping Tsai commented on HBASE-19863:
bq. So that kind of changes may cause a performance
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366819#comment-16366819
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366693#comment-16366693
]
Sergey Soldatov commented on HBASE-19863:
-
[~chia7712] I've moved the test to a separate file.
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365559#comment-16365559
]
Chia-Ping Tsai commented on HBASE-19863:
BTW, the test is not in the appropriate place. Move it
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364898#comment-16364898
]
Chia-Ping Tsai commented on HBASE-19863:
The trouble is caused by that the current kv scanner in
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364544#comment-16364544
]
Chia-Ping Tsai commented on HBASE-19863:
{quote}[~chia7712] - you have any comments?
{quote}
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364201#comment-16364201
]
ramkrishna.s.vasudevan commented on HBASE-19863:
Patch looks good to me. If the test is
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363871#comment-16363871
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363718#comment-16363718
]
Sergey Soldatov commented on HBASE-19863:
-
[~yuzhih...@gmail.com] you mean checkstyle? Addressed
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363698#comment-16363698
]
Ted Yu commented on HBASE-19863:
Lgtm
Sergey:
Can you check findbugs warnings ?
>
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363671#comment-16363671
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361916#comment-16361916
]
Sergey Soldatov commented on HBASE-19863:
-
[~ram_krish] thank you, sir! I will prepare the final
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361906#comment-16361906
]
ramkrishna.s.vasudevan commented on HBASE-19863:
I think this patch is fine. We are
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358803#comment-16358803
]
Josh Elser commented on HBASE-19863:
[~ram_krish], [~anoop.hbase], seems to me that you guys
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355179#comment-16355179
]
Anoop Sam John commented on HBASE-19863:
Ya understood the real issue. We need to make sure the
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355021#comment-16355021
]
Sergey Soldatov commented on HBASE-19863:
-
[~anoop.hbase] thank you, sir! The question is
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354998#comment-16354998
]
Anoop Sam John commented on HBASE-19863:
Yes that jira did this optimization. When we have to
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352674#comment-16352674
]
Sergey Soldatov commented on HBASE-19863:
-
bq. I agree to this. But my arg would be that if
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352088#comment-16352088
]
ramkrishna.s.vasudevan commented on HBASE-19863:
bq.So the reason for this check is only
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345868#comment-16345868
]
Sergey Soldatov commented on HBASE-19863:
-
[~ram_krish] That's an interesting question what
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345642#comment-16345642
]
Josh Elser commented on HBASE-19863:
Cool, thanks for verifying [~ram_krish]. I had just assumed they
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345389#comment-16345389
]
ramkrishna.s.vasudevan commented on HBASE-19863:
IMO both cases (the description here and
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345386#comment-16345386
]
Ted Yu commented on HBASE-19863:
I was expecting exception to come out of ScanDeleteTracker (shown in
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345370#comment-16345370
]
Josh Elser commented on HBASE-19863:
bq. With the attached test case the issue that we get is Wrong
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344814#comment-16344814
]
ramkrishna.s.vasudevan commented on HBASE-19863:
With the attached test case the issue
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344426#comment-16344426
]
Hadoop QA commented on HBASE-19863:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343845#comment-16343845
]
Sergey Soldatov commented on HBASE-19863:
-
bq. In this place we try to do a real seek right
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343829#comment-16343829
]
Ted Yu commented on HBASE-19863:
The test patch was based on branch-1.
When I ran
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343811#comment-16343811
]
Sergey Soldatov commented on HBASE-19863:
-
Attached a test case to reproduce the problem for
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342999#comment-16342999
]
ramkrishna.s.vasudevan commented on HBASE-19863:
Ok. So I had that doubt but sine it was
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342971#comment-16342971
]
Anoop Sam John commented on HBASE-19863:
bq.Two HStore A and B? It is actually one single column
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342970#comment-16342970
]
Anoop Sam John commented on HBASE-19863:
bq.So, in next() when we set new current scanner we may
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342963#comment-16342963
]
ramkrishna.s.vasudevan commented on HBASE-19863:
bq.The table has a single region with
[
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340334#comment-16340334
]
Ted Yu commented on HBASE-19863:
This case first came up during the past weekend (I was on call).
The
59 matches
Mail list logo
