[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349538#comment-16349538
]
Ted Yu commented on HBASE-19895:
Ankit:
Please take a look at the checkstyle warnings w.r.t.
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349499#comment-16349499
]
Hadoop QA commented on HBASE-19895:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345250#comment-16345250
]
Ted Yu commented on HBASE-19895:
Ankit:
Do you want to roll the fix for HBASE-19896 into this one ?
>
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344815#comment-16344815
]
Hadoop QA commented on HBASE-19895:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344797#comment-16344797
]
Ankit Singhal commented on HBASE-19895:
---
{quote}You need to also consider keepDeletedCells here.
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344807#comment-16344807
]
Duo Zhang commented on HBASE-19895:
---
+1. Let's see the pre commit result. Seems yetus 0.7.0 is not very
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344788#comment-16344788
]
Duo Zhang commented on HBASE-19895:
---
{code}
if (maxVersions == null && ttl == null) {
{code}
You need
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344735#comment-16344735
]
Hadoop QA commented on HBASE-19895:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344737#comment-16344737
]
Ankit Singhal commented on HBASE-19895:
---
Thanks [~Apache9] for taking a look.
bq. Is it always
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344743#comment-16344743
]
Duo Zhang commented on HBASE-19895:
---
Seems fine, just like the TTL and version. You can hook at every
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344717#comment-16344717
]
Hadoop QA commented on HBASE-19895:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344710#comment-16344710
]
Duo Zhang commented on HBASE-19895:
---
Is it always safe to do this? We have been trying hard to reduce
12 matches
Mail list logo
