[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407504#comment-16407504 ] Ashish Singhi commented on HBASE-20229: --- Source code fix looks ok to me. In the test code you need to cleanup the table which you have created and also close the connection at the end. > ConnectionImplementation.locateRegions() doesn't work correctly when region > replication is on > - > > Key: HBASE-20229 > URL: https://issues.apache.org/jira/browse/HBASE-20229 > Project: HBase > Issue Type: Bug >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20229.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407434#comment-16407434 ] Anoop Sam John commented on HBASE-20229: So the issue is duplicated entries in the List been returned. Every region will repeat 3 times (3 = replicas count).. Got it. Was wondering some other issue. Pls add proper description and change the title accordingly. Your patch make sense. In test we create table with one region but 3 been replicas count. The list returned should contain 3 locations.. Pls add more asserts abt the replica id of returned regions also. (That one is primary/default and others are 1 and 2 replica id).. good one. > ConnectionImplementation.locateRegions() doesn't work correctly when region > replication is on > - > > Key: HBASE-20229 > URL: https://issues.apache.org/jira/browse/HBASE-20229 > Project: HBase > Issue Type: Bug >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Attachments: HBASE-20229.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[
https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407290#comment-16407290
]
Toshihiro Suzuki commented on HBASE-20229:
--
[~anoop.hbase] [~huaxiang] Sorry for my lack of explanation.
The issue is when region replication is on,
ConnectionImplementation.locateRegions() returns wrong results.
In the test in my patch, the table should have 1 primary region + 2
secondaries, but ConnectionImplementation.locateRegions() returns 9 regions. I
think this is because the following code calls locateRegion() even for replica
regions and then the result tripled.
{code}
for (RegionInfo regionInfo : regions) {
RegionLocations list = locateRegion(tableName, regionInfo.getStartKey(),
useCache, true);
if (list != null) {
for (HRegionLocation loc : list.getRegionLocations()) {
if (loc != null) {
locations.add(loc);
}
}
}
{code}
The fix in my patch is to make it call locateRegion() only for a primary region.
Thanks
> ConnectionImplementation.locateRegions() doesn't work correctly when region
> replication is on
> -
>
> Key: HBASE-20229
> URL: https://issues.apache.org/jira/browse/HBASE-20229
> Project: HBase
> Issue Type: Bug
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20229.master.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407252#comment-16407252 ] huaxiang sun commented on HBASE-20229: -- Please describe the issue, it seems that from the test that without the fix, the locations array size is 9 instead of the 3. > ConnectionImplementation.locateRegions() doesn't work correctly when region > replication is on > - > > Key: HBASE-20229 > URL: https://issues.apache.org/jira/browse/HBASE-20229 > Project: HBase > Issue Type: Bug >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Attachments: HBASE-20229.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406752#comment-16406752 ] Anoop Sam John commented on HBASE-20229: What is the issue you are facing? Any chance for a test also for this? Ya it make sense to do locateRegion() call only on primary region. > ConnectionImplementation.locateRegions() doesn't work correctly when region > replication is on > - > > Key: HBASE-20229 > URL: https://issues.apache.org/jira/browse/HBASE-20229 > Project: HBase > Issue Type: Bug >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Attachments: HBASE-20229.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406325#comment-16406325 ] Toshihiro Suzuki commented on HBASE-20229: -- I don't think TestReplicationDroppedTables is related to the patch. The test was successful in my env. > ConnectionImplementation.locateRegions() doesn't work correctly when region > replication is on > - > > Key: HBASE-20229 > URL: https://issues.apache.org/jira/browse/HBASE-20229 > Project: HBase > Issue Type: Bug >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Attachments: HBASE-20229.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[
https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406224#comment-16406224
]
Hadoop QA commented on HBASE-20229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 10s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
10s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}119m 0s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestReplicationDroppedTables |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20229 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12915284/HBASE-20229.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 35ddb5f94821 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 2a3f4a0a4e |
| maven | version: Apache Maven 3.5.3
[jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() doesn't work correctly when region replication is on
[ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405974#comment-16405974 ] Toshihiro Suzuki commented on HBASE-20229: -- I just attached the v1 patch. > ConnectionImplementation.locateRegions() doesn't work correctly when region > replication is on > - > > Key: HBASE-20229 > URL: https://issues.apache.org/jira/browse/HBASE-20229 > Project: HBase > Issue Type: Bug >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Attachments: HBASE-20229.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
