[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497159#comment-16497159
]
Sakthi commented on HBASE-20270:
[~busbey] , Any specific errors here that you happen to recall?
> Turn
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453482#comment-16453482
]
Hudson commented on HBASE-20270:
Results for branch branch-2
[build #660 on
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453207#comment-16453207
]
Sakthi commented on HBASE-20270:
Sure, thanks.
> Turn off command help that follows all errors in shell
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453184#comment-16453184
]
Sean Busbey commented on HBASE-20270:
-
I get test failures when trying to use this on branch-1. will
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453129#comment-16453129
]
Sakthi commented on HBASE-20270:
[~busbey] , release note updated. Please check.
> Turn off command help
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452771#comment-16452771
]
Sakthi commented on HBASE-20270:
Sure [~busbey] . Will work on that. Thanks.
> Turn off command help
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452351#comment-16452351
]
Sean Busbey commented on HBASE-20270:
-
[~jatsakthi] would you mind coming up with a release note?
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452346#comment-16452346
]
Sean Busbey commented on HBASE-20270:
-
+1 going to push this to master, branch-2, and branch-1 unless
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451646#comment-16451646
]
Hadoop QA commented on HBASE-20270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451401#comment-16451401
]
Hadoop QA commented on HBASE-20270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451316#comment-16451316
]
Sakthi commented on HBASE-20270:
My bad. I overlooked the generic case handling. Will adopt the "return a
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451287#comment-16451287
]
Sean Busbey commented on HBASE-20270:
-
{code}
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451304#comment-16451304
]
Sean Busbey commented on HBASE-20270:
-
This is a great step in the right direction!
{code}
diff
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451302#comment-16451302
]
Sakthi commented on HBASE-20270:
Sure, I'll do that.
> Turn off command help that follows all errors in
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446956#comment-16446956
]
Hadoop QA commented on HBASE-20270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446948#comment-16446948
]
Sakthi commented on HBASE-20270:
Makes sense, [~busbey] . Please take a look at the patch.
(Robocop
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446580#comment-16446580
]
Sean Busbey commented on HBASE-20270:
-
great idea. current implementation is too brittle though. what
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446538#comment-16446538
]
Hadoop QA commented on HBASE-20270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446526#comment-16446526
]
Sakthi commented on HBASE-20270:
[~busbey] , I have tried something here. Could you please share your
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446240#comment-16446240
]
Sean Busbey commented on HBASE-20270:
-
{code}
diff --git
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446232#comment-16446232
]
Sakthi commented on HBASE-20270:
Sure, [~busbey] .
> Turn off command help that follows all errors in
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446224#comment-16446224
]
Sean Busbey commented on HBASE-20270:
-
please clean up the complaints from rubocop. If theyr'e things
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443808#comment-16443808
]
Hadoop QA commented on HBASE-20270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443599#comment-16443599
]
Sakthi commented on HBASE-20270:
[~mdrob] , Could you please review the patch?
> Turn off command help
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434572#comment-16434572
]
Sakthi commented on HBASE-20270:
Haven't had a chance to work on this lately. Will update soon [~stack] .
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434535#comment-16434535
]
stack commented on HBASE-20270:
---
Any luck here [~jatsakthi]?
> Turn off command help that follows all
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413436#comment-16413436
]
Sakthi commented on HBASE-20270:
[~mdrob] , thanks for your comments. Working on them.
> Turn off
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412597#comment-16412597
]
Mike Drob commented on HBASE-20270:
---
Patch looks ok, I think we should also print a line "for usage try
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412343#comment-16412343
]
Sakthi commented on HBASE-20270:
I have tested the patch manually by building a tar and testing out the
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412280#comment-16412280
]
Hadoop QA commented on HBASE-20270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412192#comment-16412192
]
Sean Busbey commented on HBASE-20270:
-
not at all!
> Turn off command help that follows all errors
[
https://issues.apache.org/jira/browse/HBASE-20270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412172#comment-16412172
]
Sakthi commented on HBASE-20270:
Hey [~busbey] , Do you mind if I assign it to myself?
> Turn off
32 matches
Mail list logo
