[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435615#comment-16435615 ] Hudson commented on HBASE-20330: Results for branch master [build #295 on

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434943#comment-16434943 ] Hudson commented on HBASE-20330: Results for branch branch-2.0 [build #161 on

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434934#comment-16434934 ] Hudson commented on HBASE-20330: Results for branch branch-2 [build #601 on

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434684#comment-16434684 ] Appy commented on HBASE-20330: -- Gave +1 on RB yesterday. > ProcedureExecutor.start() gets stuck in recover

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434545#comment-16434545 ] Umesh Agashe commented on HBASE-20330: -- @stack, if HBASE-20338 gets committed first then rebase to

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434536#comment-16434536 ] Umesh Agashe commented on HBASE-20330: -- I've addressed most review comments from all. [~appy], do

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434530#comment-16434530 ] stack commented on HBASE-20330: --- Patch looks good to me. This good to go [~uagashe] Any outstanding issues

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429392#comment-16429392 ] Hadoop QA commented on HBASE-20330: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429132#comment-16429132 ] Umesh Agashe commented on HBASE-20330: -- Sure, [~appy]. Will upload new patch. Thanks! >

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429131#comment-16429131 ] Appy commented on HBASE-20330: -- RB down for me. [~uagashe] try the suggestion, you'll see what i am saying.

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429032#comment-16429032 ] Hadoop QA commented on HBASE-20330: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429024#comment-16429024 ] Umesh Agashe commented on HBASE-20330: -- bq. The preferred idiom here is to use a final AtomicBoolean

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428989#comment-16428989 ] Mike Drob commented on HBASE-20330: --- {quote}Without final boolean array, compiler throws errors:

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428973#comment-16428973 ] Umesh Agashe commented on HBASE-20330: -- Changes per @xiaochen's review comments + fixed checkstyle

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428921#comment-16428921 ] Hadoop QA commented on HBASE-20330: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428912#comment-16428912 ] Xiao Chen commented on HBASE-20330: --- Thanks [~uagashe] for adding the unit test! I'm +1 (non-binding),

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428901#comment-16428901 ] Hadoop QA commented on HBASE-20330: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428886#comment-16428886 ] Umesh Agashe commented on HBASE-20330: -- Thanks for review comments [~jojochuang], please see patch

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428840#comment-16428840 ] Wei-Chiu Chuang commented on HBASE-20330: - Don't know the implementation in details, but found a

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428826#comment-16428826 ] stack commented on HBASE-20330: --- LGTM Thanks for adding unit test. This is rare in operation so the unit

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428825#comment-16428825 ] Wei-Chiu Chuang commented on HBASE-20330: - Thanks [~uagashe] Updated the patch to address your

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428816#comment-16428816 ] Umesh Agashe commented on HBASE-20330: -- Changes per review comments. * Made

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427510#comment-16427510 ] Mike Drob commented on HBASE-20330: --- rollWriter needs to be called with the lock held, so

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427393#comment-16427393 ] Umesh Agashe commented on HBASE-20330: -- Also note that in existing code, separate method is

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427386#comment-16427386 ] Umesh Agashe commented on HBASE-20330: -- Thanks [~mdrob]! okay, will work on it. >

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427383#comment-16427383 ] Mike Drob commented on HBASE-20330: --- public and visible for testing is generally fine, as long as we

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427277#comment-16427277 ] Umesh Agashe commented on HBASE-20330: -- Thanks [~xiaochen]! regarding concerns about listStatus()

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427250#comment-16427250 ] Xiao Chen commented on HBASE-20330: --- Thanks [~uagashe], I'm not an hbase expert, just some thoughts in

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426351#comment-16426351 ] Hadoop QA commented on HBASE-20330: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426323#comment-16426323 ] Umesh Agashe commented on HBASE-20330: -- [~appy], [~xiaochen], can you please review the changes? >

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424808#comment-16424808 ] Umesh Agashe commented on HBASE-20330: -- Thanks for the details, [~appy]. Will upload the patch soon.

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424703#comment-16424703 ] Appy commented on HBASE-20330: -- we can probably fix this easily by refreshing the list of log files in start

[jira] [Commented] (HBASE-20330) ProcedureExecutor.start() gets stuck in recover lease on store.

[ https://issues.apache.org/jira/browse/HBASE-20330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424695#comment-16424695 ] Appy commented on HBASE-20330: -- Hard to reproduce problem. Our hypothesis was, if a master during startup