[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517686#comment-16517686
]
Hudson commented on HBASE-20332:
Results for branch master
[build #370 on
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516559#comment-16516559
]
Hudson commented on HBASE-20332:
Results for branch branch-2
[build #878 on
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516122#comment-16516122
]
Sean Busbey commented on HBASE-20332:
-
thanks!
filed HBASE-20749.
> shaded mapreduce module
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516109#comment-16516109
]
Mike Drob commented on HBASE-20332:
---
Please file a follow on jira for upgrading our checkstyle version
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516108#comment-16516108
]
Mike Drob commented on HBASE-20332:
---
{code:title=checkstyle-suppressions.xml}
+ TODO Update to use
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515673#comment-16515673
]
Hadoop QA commented on HBASE-20332:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515471#comment-16515471
]
Sean Busbey commented on HBASE-20332:
-
-v7
- comment out the checkstyle based checking for HTrace
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515278#comment-16515278
]
Sean Busbey commented on HBASE-20332:
-
If I start from an empty maven repository it fails locally
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514839#comment-16514839
]
Sean Busbey commented on HBASE-20332:
-
ugh. checkstyle in hte precommit run broke with a complaint
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514464#comment-16514464
]
Hadoop QA commented on HBASE-20332:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514263#comment-16514263
]
Mike Drob commented on HBASE-20332:
---
+1
> shaded mapreduce module shouldn't include hadoop
>
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514152#comment-16514152
]
Sean Busbey commented on HBASE-20332:
-
-v6
- suppresses IllegalImport complaints when they involve
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514122#comment-16514122
]
Hadoop QA commented on HBASE-20332:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514024#comment-16514024
]
Sean Busbey commented on HBASE-20332:
-
{quote}
The reason I'm concerned about the checkstyle issues
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513993#comment-16513993
]
Mike Drob commented on HBASE-20332:
---
The reason I'm concerned about the checkstyle issues is because I
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513970#comment-16513970
]
Sean Busbey commented on HBASE-20332:
-
okay I got it.
the checkstyle output itself is not zero:
*
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513891#comment-16513891
]
Sean Busbey commented on HBASE-20332:
-
the branch and patch checkstyle output files are both size 0.
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513398#comment-16513398
]
Hadoop QA commented on HBASE-20332:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513236#comment-16513236
]
Sean Busbey commented on HBASE-20332:
-
v5
- rebased onto master to pick up the changes in
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512807#comment-16512807
]
Sean Busbey commented on HBASE-20332:
-
filed HBASE-20733
> shaded mapreduce module shouldn't
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512795#comment-16512795
]
Sean Busbey commented on HBASE-20332:
-
okay by default checkstyle is only run when a java file
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512713#comment-16512713
]
Sean Busbey commented on HBASE-20332:
-
hurm. none of the changed file types queued up a checkstyle
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512703#comment-16512703
]
Hadoop QA commented on HBASE-20332:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512636#comment-16512636
]
Sean Busbey commented on HBASE-20332:
-
hurm. that's a good question. let me take a look.
> shaded
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512548#comment-16512548
]
Mike Drob commented on HBASE-20332:
---
Any idea why checkstyle didn't run on precommit? I would have
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508629#comment-16508629
]
Hadoop QA commented on HBASE-20332:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508456#comment-16508456
]
Sean Busbey commented on HBASE-20332:
-
{quote}
Since we're removing the exclusion in a bunch of
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508452#comment-16508452
]
Sean Busbey commented on HBASE-20332:
-
removing hadoop from the shaded mapreduce module means
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508247#comment-16508247
]
Mike Drob commented on HBASE-20332:
---
I'm confused what's going on with htrace here?
> shaded
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508211#comment-16508211
]
Sean Busbey commented on HBASE-20332:
-
-v4
- rebased to current master
- removes the precommit
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502096#comment-16502096
]
Josh Elser commented on HBASE-20332:
{quote}everyone fine with me punting the check for old hbase
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454686#comment-16454686
]
Sean Busbey commented on HBASE-20332:
-
given the current status of checkstyle based check in
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450044#comment-16450044
]
Sean Busbey commented on HBASE-20332:
-
bq. What is the dependency relationship between this issue and
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449962#comment-16449962
]
Mike Drob commented on HBASE-20332:
---
bq. Yes. I have another jira that's a sibling to this one to make
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448955#comment-16448955
]
Sean Busbey commented on HBASE-20332:
-
filed and put up a patch to start having a footer for
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448829#comment-16448829
]
Sean Busbey commented on HBASE-20332:
-
{quote}
patch you uploaded appears to actually be 4 patches,
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446206#comment-16446206
]
Mike Drob commented on HBASE-20332:
---
patch you uploaded appears to actually be 4 patches, the first
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446167#comment-16446167
]
Sean Busbey commented on HBASE-20332:
-
filed HBASE-20467 for the duplicative work in checkstyle
>
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446160#comment-16446160
]
Sean Busbey commented on HBASE-20332:
-
unit test failures are all timeouts. probably unreleated, let
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446157#comment-16446157
]
Sean Busbey commented on HBASE-20332:
-
the hbaseanti flags are the lines in the test I added. :)
>
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446059#comment-16446059
]
Hadoop QA commented on HBASE-20332:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445662#comment-16445662
]
Sean Busbey commented on HBASE-20332:
-
v3 correct unit test failures
- added a precommit check for
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445658#comment-16445658
]
Hadoop QA commented on HBASE-20332:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445052#comment-16445052
]
Sean Busbey commented on HBASE-20332:
-
those are definitely related failures. probably some
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445051#comment-16445051
]
Sean Busbey commented on HBASE-20332:
-
okay v2 checked out via running the commands on cluster with
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444934#comment-16444934
]
Hadoop QA commented on HBASE-20332:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443368#comment-16443368
]
Hadoop QA commented on HBASE-20332:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441107#comment-16441107
]
stack commented on HBASE-20332:
---
Go [~busbey]! This is hard work.
> shaded mapreduce module shouldn't
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440964#comment-16440964
]
Sean Busbey commented on HBASE-20332:
-
bq. But I think I have a deeper problem than that. As you
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440903#comment-16440903
]
Sean Busbey commented on HBASE-20332:
-
one additional note on the "especially #1 and #2 above", the
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440898#comment-16440898
]
Sean Busbey commented on HBASE-20332:
-
{quote}
How's this work relate to what we have in guide since
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440540#comment-16440540
]
stack commented on HBASE-20332:
---
How's this work relate to what we have in guide since time immemorial?
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440089#comment-16440089
]
Sean Busbey commented on HBASE-20332:
-
yay! workaround via {{HADOOP_USER_CLASSPATH_FIRST=true}} looks
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440079#comment-16440079
]
Sean Busbey commented on HBASE-20332:
-
okay the export snapshot failure is a polluted classpath in my
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440030#comment-16440030
]
Sean Busbey commented on HBASE-20332:
-
things to check still
# the export snapshot failure
#
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440026#comment-16440026
]
Sean Busbey commented on HBASE-20332:
-
Okay I've gone through most of the built in MR jobs:
{code}
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439925#comment-16439925
]
Sean Busbey commented on HBASE-20332:
-
those shellcheck and whitespace things should be easy enough
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439911#comment-16439911
]
Hadoop QA commented on HBASE-20332:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439846#comment-16439846
]
Sean Busbey commented on HBASE-20332:
-
to test out, first do a local install so you can get what the
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424156#comment-16424156
]
Sean Busbey commented on HBASE-20332:
-
I think the appropriate scope for the hadoop bits we need on
[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424152#comment-16424152
]
Sean Busbey commented on HBASE-20332:
-
re #1, you currently can't use our shaded mapreduce jar to
61 matches
Mail list logo