[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-06 Thread Umesh Agashe (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428769#comment-16428769 ] Umesh Agashe commented on HBASE-20338: -- +1 lgtm nits: * You may want to consider ch

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428706#comment-16428706 ] Mike Drob commented on HBASE-20338: --- It's not! {noformat} mdrob@mdrob-MBP:~$ jshell |

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-06 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428695#comment-16428695 ] Wei-Chiu Chuang commented on HBASE-20338: - Hi Mike, it is effectively the same as

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428661#comment-16428661 ] Mike Drob commented on HBASE-20338: --- Did you mean post increment? > WALProcedureStore#

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428237#comment-16428237 ] Hadoop QA commented on HBASE-20338: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-06 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428153#comment-16428153 ] Wei-Chiu Chuang commented on HBASE-20338: - Thanks [~chia7712] for the review! No

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-05 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428007#comment-16428007 ] Chia-Ping Tsai commented on HBASE-20338: Is it necessary to sleep when doing the

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427657#comment-16427657 ] Hadoop QA commented on HBASE-20338: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-04 Thread Umesh Agashe (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426100#comment-16426100 ] Umesh Agashe commented on HBASE-20338: -- Thanks for taking this [~jojochuang]! > WAL

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-03 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424937#comment-16424937 ] Wei-Chiu Chuang commented on HBASE-20338: - Hi Umesh, I'd like to work on this imp

[jira] [Commented] (HBASE-20338) WALProcedureStore#recoverLease() should have fixed sleeps and/ or exponential backoff for retrying rollWriter()

2018-04-03 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424640#comment-16424640 ] Wei-Chiu Chuang commented on HBASE-20338: - This is interesting – typically if the