[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528822#comment-16528822
]
Pankaj Kumar commented on HBASE-20357:
--
Ok... Thanks [~Apache9]
> AccessControlClient API
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528723#comment-16528723
]
Duo Zhang commented on HBASE-20357:
---
The patch is big so let's include in 2.2 as 2.1 will be released
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528410#comment-16528410
]
Hudson commented on HBASE-20357:
Results for branch branch-2
[build #924 on
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527806#comment-16527806
]
Pankaj Kumar commented on HBASE-20357:
--
Thanks [~yuzhih...@gmail.com] for reviewing and committing
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527726#comment-16527726
]
Hudson commented on HBASE-20357:
Results for branch master
[build #380 on
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527278#comment-16527278
]
Ted Yu commented on HBASE-20357:
I guess the 2.2 client should wait for server upgrade.
Let's wait for
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527273#comment-16527273
]
Ashish Singhi commented on HBASE-20357:
---
Do we support that scenario ?
> AccessControlClient API
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527266#comment-16527266
]
Ted Yu commented on HBASE-20357:
Yes.
> AccessControlClient API Enhancement
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527251#comment-16527251
]
Ashish Singhi commented on HBASE-20357:
---
{quote}If hbase 2.2 AccessControlClient (with this
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527245#comment-16527245
]
Ted Yu commented on HBASE-20357:
If hbase 2.2 AccessControlClient (with this change) calls
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527239#comment-16527239
]
Hadoop QA commented on HBASE-20357:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527230#comment-16527230
]
Pankaj Kumar commented on HBASE-20357:
--
There is no change in the old existing APIs behaviour, only
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527219#comment-16527219
]
Ted Yu commented on HBASE-20357:
AccessControlClient is marked InterfaceAudience.Public
If this goes to
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527217#comment-16527217
]
Pankaj Kumar commented on HBASE-20357:
--
Please commit in branch-2 also, v3 can be applied there
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527214#comment-16527214
]
Ted Yu commented on HBASE-20357:
Just committed patch v3.
Please attach addendum.
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527211#comment-16527211
]
Pankaj Kumar commented on HBASE-20357:
--
Please review the release notes.
I will update the acl
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522157#comment-16522157
]
Ted Yu commented on HBASE-20357:
Please fill out release note.
> AccessControlClient API Enhancement
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522152#comment-16522152
]
Ted Yu commented on HBASE-20357:
+1
> AccessControlClient API Enhancement
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522102#comment-16522102
]
Hadoop QA commented on HBASE-20357:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521928#comment-16521928
]
Pankaj Kumar commented on HBASE-20357:
--
Have uploaded V3 patch, addressed the review comments and
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520799#comment-16520799
]
Hadoop QA commented on HBASE-20357:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520764#comment-16520764
]
Ted Yu commented on HBASE-20357:
There are 3 pairs of
bq. result.getParams().addExtraParam("filterUser",
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520659#comment-16520659
]
Pankaj Kumar commented on HBASE-20357:
--
Uploaded 002 patch, addressed the RB comments, checkstyle
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503372#comment-16503372
]
Ted Yu commented on HBASE-20357:
I briefly went over the additions in TestAccessController.java which
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503108#comment-16503108
]
Pankaj Kumar commented on HBASE-20357:
--
{quote}Since the patch is relatively large, please spin up
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502258#comment-16502258
]
Nihal Jain commented on HBASE-20357:
The docstring of AccessChecker.requirePermission(User, String,
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502243#comment-16502243
]
Nihal Jain commented on HBASE-20357:
Changes in {{RSGroupAdminEndpoint}} are fine as we need not
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502189#comment-16502189
]
Ted Yu commented on HBASE-20357:
Pankaj:
Since the patch is relatively large, please spin up a secure
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502030#comment-16502030
]
Ted Yu commented on HBASE-20357:
[~nihaljain.cs]:
Since you're familiar with RS group code, can you take
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501765#comment-16501765
]
Pankaj Kumar commented on HBASE-20357:
--
Have uploaded the patch in RB,
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500116#comment-16500116
]
Ashish Singhi commented on HBASE-20357:
---
Can you please upload the patch in RB.
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499576#comment-16499576
]
Hadoop QA commented on HBASE-20357:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
32 matches
Mail list logo
