[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554244#comment-16554244 ] Hudson commented on HBASE-20565: Results for branch master [build #407 on

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554110#comment-16554110 ] Hudson commented on HBASE-20565: Results for branch branch-2.1 [build #98 on

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554075#comment-16554075 ] Hudson commented on HBASE-20565: Results for branch branch-1 [build #391 on

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554078#comment-16554078 ] Hudson commented on HBASE-20565: Results for branch branch-2.0 [build #586 on

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554048#comment-16554048 ] Hudson commented on HBASE-20565: Results for branch branch-2 [build #1020 on

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-23 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553707#comment-16553707 ] Zheng Hu commented on HBASE-20565: -- Hadoop QA for branch-1 did not run, but I run under my local , it

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-23 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553515#comment-16553515 ] Andrew Purtell commented on HBASE-20565: +1 for branch-1 and branch-1.4 > ColumnRangeFilter

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552373#comment-16552373 ] Hadoop QA commented on HBASE-20565: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-22 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552243#comment-16552243 ] Zheng Hu commented on HBASE-20565: -- Thanks [~yuzhih...@gmail.com] & [~jinghe], I've uploaded the

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550535#comment-16550535 ] Ted Yu commented on HBASE-20565: Zheng: Can you attach patch for branch-1 ? {code} +

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-20 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550281#comment-16550281 ] Jerry He commented on HBASE-20565: -- {quote}place the count-related filters at the last position {quote}

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550244#comment-16550244 ] Ted Yu commented on HBASE-20565: I ran the new test with ColumnPaginationFilter placed first in

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550193#comment-16550193 ] Zheng Hu commented on HBASE-20565: -- bq. I am yet to see the relationship between SQL and FilterList.

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550187#comment-16550187 ] Ted Yu commented on HBASE-20565: I am yet to see the relationship between SQL and FilterList. If you're

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550132#comment-16550132 ] Zheng Hu commented on HBASE-20565: -- Only for those filters who maintain some row-global state such as

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549477#comment-16549477 ] Ted Yu commented on HBASE-20565: I think filter order independence is important. MUST_PASS_ALL should

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549253#comment-16549253 ] Zheng Hu commented on HBASE-20565: -- bq. FilterList can make corresponding ordering adjustment without

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549156#comment-16549156 ] Ted Yu commented on HBASE-20565: Can we introduce some method in Filter which tells FilterList that the

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549143#comment-16549143 ] Zheng Hu commented on HBASE-20565: -- Got your mind, but I don't think it's a good taste... >

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549138#comment-16549138 ] Ted Yu commented on HBASE-20565: What I meant is to use instanceof checks against ColumnRangeFilter and

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549135#comment-16549135 ] Zheng Hu commented on HBASE-20565: -- [~yuzhih...@gmail.com], I think you mean {code} filterList =

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549103#comment-16549103 ] Ted Yu commented on HBASE-20565: Can we arrange the order of ColumnRangeFilter and

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548776#comment-16548776 ] Zheng Hu commented on HBASE-20565: -- [~reidchan] This patch do not fix the problem in HBASE-20151...

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548702#comment-16548702 ] Reid Chan commented on HBASE-20565: --- Can you try your patch with the described test cases in

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548680#comment-16548680 ] Zheng Hu commented on HBASE-20565: -- Any other concerns ? [~yuzhih...@gmail.com], [~jinghe],

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548679#comment-16548679 ] Zheng Hu commented on HBASE-20565: -- bq. If the order of filters in the FilterList changes, e.g. It's

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548415#comment-16548415 ] Hadoop QA commented on HBASE-20565: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547639#comment-16547639 ] Ted Yu commented on HBASE-20565: I am a little curious about the following change: {code}

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547634#comment-16547634 ] Ted Yu commented on HBASE-20565: If the order of filters in the FilterList changes, e.g. {code}

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-18 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547492#comment-16547492 ] Zheng Hu commented on HBASE-20565: -- Upload the patch.v2 to fix the UT. Thanks [~yuzhih...@gmail.com].

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546711#comment-16546711 ] Hadoop QA commented on HBASE-20565: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546709#comment-16546709 ] Ted Yu commented on HBASE-20565: Running Filter tests with patch I got: {code} [ERROR]

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-17 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546584#comment-16546584 ] Zheng Hu commented on HBASE-20565: -- Upload the patch.v1, and pasted the discuss with [~anoop.hbase]

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-15 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544805#comment-16544805 ] Jerry He commented on HBASE-20565: -- [~openinx] Thanks for the update. I can twist the application to

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-15 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544730#comment-16544730 ] Zheng Hu commented on HBASE-20565: -- [~jinghe], I've talked with [~anoop.hbase], I think we have a basic

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-07-12 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541187#comment-16541187 ] Jerry He commented on HBASE-20565: -- [~openinx] Is there any good news on this one? I think we need to

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480113#comment-16480113 ] Ted Yu commented on HBASE-20565: bq. so the x is unstable You mean the number of cells is unpredictable.

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-17 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480099#comment-16480099 ] Zheng Hu commented on HBASE-20565: -- bq. Is the scenario limited to FilterListWithAND only ? No ,

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480083#comment-16480083 ] Ted Yu commented on HBASE-20565: Is the scenario limited to FilterListWithAND only ? If so, we can

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-17 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480080#comment-16480080 ] Zheng Hu commented on HBASE-20565: -- bq. Is it possible to formalize the condition(s) where Max Step Rule

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480069#comment-16480069 ] Ted Yu commented on HBASE-20565: bq. FilterList concated by ColumnRangeFilter & ColumnPaginationFilter

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-17 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480064#comment-16480064 ] Zheng Hu commented on HBASE-20565: -- FilterList concated by ColumnRangeFilter & ColumnPaginationFilter

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-13 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473750#comment-16473750 ] Zheng Hu commented on HBASE-20565: -- In branch 1.2, if A's return code is not INCLUDE_*, then just

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-13 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473738#comment-16473738 ] Zheng Hu commented on HBASE-20565: -- It's complex now...if a FilterListWithAND has two sub filters A & B,

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-11 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472775#comment-16472775 ] Jerry He commented on HBASE-20565: -- You can see the results from branch-1.2 makes more sense and have

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-11 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472774#comment-16472774 ] Jerry He commented on HBASE-20565: -- Hi, [~openinx] Thanks for taking a look! i did a little more

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-11 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471531#comment-16471531 ] Zheng Hu commented on HBASE-20565: -- Oh, change my mind now, it's not bug for branch-1.4, see below:

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-10 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471467#comment-16471467 ] Zheng Hu commented on HBASE-20565: -- Add some log by debug.diff, and the result is shown in debug.log. I

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-10 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471417#comment-16471417 ] Zheng Hu commented on HBASE-20565: -- [~jinghe], Thanks for your report. Seems like it's a bug. Let me

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-10 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471024#comment-16471024 ] Jerry He commented on HBASE-20565: -- Some research shows it is caused by HBASE-18993. FYI . [~openinx],

[jira] [Commented] (HBASE-20565) ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result since 1.4

2018-05-10 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471010#comment-16471010 ] Jerry He commented on HBASE-20565: -- I attached a test case that can be used to re-create the problem.