[jira] [Commented] (HBASE-20620) Tighter ByteBufferKeyValue Cell Comparator; part 2
[
https://issues.apache.org/jira/browse/HBASE-20620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488951#comment-16488951
]
Hudson commented on HBASE-20620:
Results for branch master
[build #343 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/343/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/343//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/343//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/343//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Tighter ByteBufferKeyValue Cell Comparator; part 2
> --
>
> Key: HBASE-20620
> URL: https://issues.apache.org/jira/browse/HBASE-20620
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20620.branch-2.0.001.patch,
> HBASE-20620.branch-2.0.002.patch, HBASE-20620.branch-2.0.003.patch, hits.png
>
>
> This is a follow-on from HBASE-20564 "Tighter ByteBufferKeyValue Cell
> Comparator". In this issue, we make a stripped-down comparator that we deploy
> in one location only, as memstore Comparator. HBASE-20564 operated on
> CellComparator/Impl and got us 5-10k more throughput on top of a baseline 40k
> or so. A purposed stripped-down ByteBufferKeyValue comparator that fosters
> better inlining gets us from 45-50k up to about 75k (1.4 does 110-115k no-WAL
> PE writes). Data coming. Log of profiling kept here:
> https://docs.google.com/document/d/1vZ_k6_pNR1eQxID5u1xFihuPC7FkPaJQW8c4M5eA2AQ/edit#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20620) Tighter ByteBufferKeyValue Cell Comparator; part 2
[
https://issues.apache.org/jira/browse/HBASE-20620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488421#comment-16488421
]
Hudson commented on HBASE-20620:
Results for branch branch-2
[build #775 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/775/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/775//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/775//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/775//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Tighter ByteBufferKeyValue Cell Comparator; part 2
> --
>
> Key: HBASE-20620
> URL: https://issues.apache.org/jira/browse/HBASE-20620
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20620.branch-2.0.001.patch,
> HBASE-20620.branch-2.0.002.patch, HBASE-20620.branch-2.0.003.patch, hits.png
>
>
> This is a follow-on from HBASE-20564 "Tighter ByteBufferKeyValue Cell
> Comparator". In this issue, we make a stripped-down comparator that we deploy
> in one location only, as memstore Comparator. HBASE-20564 operated on
> CellComparator/Impl and got us 5-10k more throughput on top of a baseline 40k
> or so. A purposed stripped-down ByteBufferKeyValue comparator that fosters
> better inlining gets us from 45-50k up to about 75k (1.4 does 110-115k no-WAL
> PE writes). Data coming. Log of profiling kept here:
> https://docs.google.com/document/d/1vZ_k6_pNR1eQxID5u1xFihuPC7FkPaJQW8c4M5eA2AQ/edit#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20620) Tighter ByteBufferKeyValue Cell Comparator; part 2
[
https://issues.apache.org/jira/browse/HBASE-20620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488392#comment-16488392
]
Hudson commented on HBASE-20620:
Results for branch branch-2.0
[build #340 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/340/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/340//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/340//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/340//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Tighter ByteBufferKeyValue Cell Comparator; part 2
> --
>
> Key: HBASE-20620
> URL: https://issues.apache.org/jira/browse/HBASE-20620
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20620.branch-2.0.001.patch,
> HBASE-20620.branch-2.0.002.patch, HBASE-20620.branch-2.0.003.patch, hits.png
>
>
> This is a follow-on from HBASE-20564 "Tighter ByteBufferKeyValue Cell
> Comparator". In this issue, we make a stripped-down comparator that we deploy
> in one location only, as memstore Comparator. HBASE-20564 operated on
> CellComparator/Impl and got us 5-10k more throughput on top of a baseline 40k
> or so. A purposed stripped-down ByteBufferKeyValue comparator that fosters
> better inlining gets us from 45-50k up to about 75k (1.4 does 110-115k no-WAL
> PE writes). Data coming. Log of profiling kept here:
> https://docs.google.com/document/d/1vZ_k6_pNR1eQxID5u1xFihuPC7FkPaJQW8c4M5eA2AQ/edit#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20620) Tighter ByteBufferKeyValue Cell Comparator; part 2
[
https://issues.apache.org/jira/browse/HBASE-20620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487856#comment-16487856
]
Hadoop QA commented on HBASE-20620:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
34s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
7s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
44s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} hbase-common: The patch generated 4 new + 293
unchanged - 1 fixed = 297 total (was 294) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} hbase-server: The patch generated 0 new + 253
unchanged - 3 fixed = 253 total (was 256) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
9s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
16s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}102m
36s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}148m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:369877d |
| JIRA Issue | HBASE-20620 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12924780/HBASE-20620.branch-2.0.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8df5591d0676 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
|
