[jira] [Commented] (HBASE-20762) precommit should archive generated LICENSE file

2018-06-20 Thread Mike Drob (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-20762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518492#comment-16518492
 ] 

Mike Drob commented on HBASE-20762:
---

I went looking again and found the file in 
https://builds.apache.org/job/PreCommit-HBASE-Build/13290/artifact/component/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE/*view*/

I'm not sure why I was expecting it in patchprocess. I still think that 
printing a snippet from it in the maven output would be helpful though.

> precommit should archive generated LICENSE file
> ---
>
> Key: HBASE-20762
> URL: https://issues.apache.org/jira/browse/HBASE-20762
> Project: HBase
>  Issue Type: Bug
>  Components: build, community
>Reporter: Mike Drob
>Priority: Major
>
> When a precommit run fails due to license issues, we get pointed to a file in 
> our maven logs:
> {noformat}
> /testptch/hbase/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE
> {noformat}
> But we don't have that file saved, so we don't know what the actual failure 
> was. So we should save that in our build artifacts. Or maybe we can print a 
> snippet from that file directly into the maven log. Both would be acceptable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20762) precommit should archive generated LICENSE file

2018-06-20 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-20762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518460#comment-16518460
 ] 

Sean Busbey commented on HBASE-20762:
-

could you point me at such a failed build? I just want to confirm we're not 
getting the file but in a confusing place.

> precommit should archive generated LICENSE file
> ---
>
> Key: HBASE-20762
> URL: https://issues.apache.org/jira/browse/HBASE-20762
> Project: HBase
>  Issue Type: Bug
>  Components: build, community
>Reporter: Mike Drob
>Priority: Major
>
> When a precommit run fails due to license issues, we get pointed to a file in 
> our maven logs:
> {noformat}
> /testptch/hbase/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE
> {noformat}
> But we don't have that file saved, so we don't know what the actual failure 
> was. So we should save that in our build artifacts. Or maybe we can print a 
> snippet from that file directly into the maven log. Both would be acceptable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20762) precommit should archive generated LICENSE file

2018-06-20 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-20762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518459#comment-16518459
 ] 

Sean Busbey commented on HBASE-20762:
-

our jenkins job tries to do this now, here's our Archive artifacts:

{code}
patchprocess/*, patchprocess/**/*,**/LICENSE,**/NOTICE
{code}

Probably we should change the list of things we tell yetus to save. YETUS_ARGS 
parameter has {{--archive-list=rat.txt}} and we should update that to include 
LICENSE and NOTICE.

> precommit should archive generated LICENSE file
> ---
>
> Key: HBASE-20762
> URL: https://issues.apache.org/jira/browse/HBASE-20762
> Project: HBase
>  Issue Type: Bug
>  Components: build, community
>Reporter: Mike Drob
>Priority: Major
>
> When a precommit run fails due to license issues, we get pointed to a file in 
> our maven logs:
> {noformat}
> /testptch/hbase/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE
> {noformat}
> But we don't have that file saved, so we don't know what the actual failure 
> was. So we should save that in our build artifacts. Or maybe we can print a 
> snippet from that file directly into the maven log. Both would be acceptable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)