[jira] [Commented] (HBASE-20780) ServerRpcConnection logging cleanup
[
https://issues.apache.org/jira/browse/HBASE-20780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523750#comment-16523750
]
Hudson commented on HBASE-20780:
Results for branch master
[build #377 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/377/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/377//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/377//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/377//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ServerRpcConnection logging cleanup
> ---
>
> Key: HBASE-20780
> URL: https://issues.apache.org/jira/browse/HBASE-20780
> Project: HBase
> Issue Type: Sub-task
> Components: logging, Performance
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 2.0.2
>
> Attachments: 2.0621.2.12782.lock.svg, 2.0621.2M.46340.lock.svg,
> 2.0623.111354.lock.svg, HBASE-20780.branch-2.0.001.patch,
> HBASE-20780.branch-2.0.001.patch
>
>
> The logging we do inside in connection header parsing shows as worst offender
> in the perf locking profiles. Its odd, but easy to clean up. I'd doubt it
> makes any difference in throughput but lets get it out of the way. Let me
> load up a few samples of what it current looks like.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20780) ServerRpcConnection logging cleanup
[
https://issues.apache.org/jira/browse/HBASE-20780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523217#comment-16523217
]
Hudson commented on HBASE-20780:
Results for branch branch-2.0
[build #474 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/474/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/474//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/474//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/474//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> ServerRpcConnection logging cleanup
> ---
>
> Key: HBASE-20780
> URL: https://issues.apache.org/jira/browse/HBASE-20780
> Project: HBase
> Issue Type: Sub-task
> Components: logging, Performance
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 2.0.2
>
> Attachments: 2.0621.2.12782.lock.svg, 2.0621.2M.46340.lock.svg,
> 2.0623.111354.lock.svg, HBASE-20780.branch-2.0.001.patch,
> HBASE-20780.branch-2.0.001.patch
>
>
> The logging we do inside in connection header parsing shows as worst offender
> in the perf locking profiles. Its odd, but easy to clean up. I'd doubt it
> makes any difference in throughput but lets get it out of the way. Let me
> load up a few samples of what it current looks like.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20780) ServerRpcConnection logging cleanup
[
https://issues.apache.org/jira/browse/HBASE-20780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523195#comment-16523195
]
Hudson commented on HBASE-20780:
Results for branch branch-2
[build #908 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/908/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/908//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/908//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/908//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ServerRpcConnection logging cleanup
> ---
>
> Key: HBASE-20780
> URL: https://issues.apache.org/jira/browse/HBASE-20780
> Project: HBase
> Issue Type: Sub-task
> Components: logging, Performance
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 2.0.2
>
> Attachments: 2.0621.2.12782.lock.svg, 2.0621.2M.46340.lock.svg,
> 2.0623.111354.lock.svg, HBASE-20780.branch-2.0.001.patch,
> HBASE-20780.branch-2.0.001.patch
>
>
> The logging we do inside in connection header parsing shows as worst offender
> in the perf locking profiles. Its odd, but easy to clean up. I'd doubt it
> makes any difference in throughput but lets get it out of the way. Let me
> load up a few samples of what it current looks like.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20780) ServerRpcConnection logging cleanup
[
https://issues.apache.org/jira/browse/HBASE-20780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521404#comment-16521404
]
Hadoop QA commented on HBASE-20780:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
9s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
24s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
16s{color} | {color:red} hbase-server: The patch generated 1 new + 23 unchanged
- 1 fixed = 24 total (was 24) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}159m
12s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}209m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:6f01af0 |
| JIRA Issue | HBASE-20780 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928897/HBASE-20780.branch-2.0.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6e2da23a8fab 4.4.0-98-generic #121-Ubuntu SMP Tue Oct 10
14:24:03 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2.0 / 691fea2b03 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/13362/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
[jira] [Commented] (HBASE-20780) ServerRpcConnection logging cleanup
[ https://issues.apache.org/jira/browse/HBASE-20780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521360#comment-16521360 ] stack commented on HBASE-20780: --- .001 cleans up logging. Removes an instance. Aggregates all logging in one line. See how it seems to remove logging as a lock hump in posted profile [^2.0623.111354.lock.svg] > ServerRpcConnection logging cleanup > --- > > Key: HBASE-20780 > URL: https://issues.apache.org/jira/browse/HBASE-20780 > Project: HBase > Issue Type: Sub-task > Components: logging, Performance >Reporter: stack >Assignee: stack >Priority: Major > Attachments: 2.0621.2.12782.lock.svg, 2.0621.2M.46340.lock.svg, > 2.0623.111354.lock.svg, HBASE-20780.branch-2.0.001.patch, > HBASE-20780.branch-2.0.001.patch > > > The logging we do inside in connection header parsing shows as worst offender > in the perf locking profiles. Its odd, but easy to clean up. I'd doubt it > makes any difference in throughput but lets get it out of the way. Let me > load up a few samples of what it current looks like. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20780) ServerRpcConnection logging cleanup
[ https://issues.apache.org/jira/browse/HBASE-20780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521356#comment-16521356 ] stack commented on HBASE-20780: --- You can see how logging is the most prominent peek in the two profiles posted.. .one with defaults [^2.0621.2.12782.lock.svg] and second with 2MB async WAL buffer size [^2.0621.2M.46340.lock.svg] (especially bad in second case). > ServerRpcConnection logging cleanup > --- > > Key: HBASE-20780 > URL: https://issues.apache.org/jira/browse/HBASE-20780 > Project: HBase > Issue Type: Sub-task > Components: logging, Performance >Reporter: stack >Assignee: stack >Priority: Major > Attachments: 2.0621.2.12782.lock.svg, 2.0621.2M.46340.lock.svg > > > The logging we do inside in connection header parsing shows as worst offender > in the perf locking profiles. Its odd, but easy to clean up. I'd doubt it > makes any difference in throughput but lets get it out of the way. Let me > load up a few samples of what it current looks like. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
