[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689421#comment-16689421
]
Sean Busbey commented on HBASE-21255:
-
heads up on HBASE-21489. please take a look.
> [acl]
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688329#comment-16688329
]
Hudson commented on HBASE-21255:
Results for branch branch-2
[build #1504 on
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687866#comment-16687866
]
Hudson commented on HBASE-21255:
Results for branch master
[build #607 on
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687449#comment-16687449
]
Reid Chan commented on HBASE-21255:
---
Pushed to branch-2 and master.
Thanks all for reviews and
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687318#comment-16687318
]
Reid Chan commented on HBASE-21255:
---
The checkstyle is about {{ShadedAccessControlUtil}}. Like this:
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686791#comment-16686791
]
stack commented on HBASE-21255:
---
Skimmed. +1. Fix checkstyle on commit? Looks good. Saved 7k!
> [acl]
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686445#comment-16686445
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686244#comment-16686244
]
Reid Chan commented on HBASE-21255:
---
Retry v9.
> [acl] Refactor TablePermission into three classes
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686238#comment-16686238
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686047#comment-16686047
]
Reid Chan commented on HBASE-21255:
---
bq. address code duplication
As suggestion, it is much cleaner.
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685710#comment-16685710
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685461#comment-16685461
]
stack commented on HBASE-21255:
---
You did not address code duplication in you last patch [~reidchan]?
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684636#comment-16684636
]
Reid Chan commented on HBASE-21255:
---
Unrelated failure.
> [acl] Refactor TablePermission into three
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684370#comment-16684370
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684268#comment-16684268
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683995#comment-16683995
]
Reid Chan commented on HBASE-21255:
---
Attached a wrong v8 patch
Re-upload it.
> [acl] Refactor
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683936#comment-16683936
]
Reid Chan commented on HBASE-21255:
---
v8 addressed comments from [~stack] in RB.
> [acl] Refactor
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680751#comment-16680751
]
Reid Chan commented on HBASE-21255:
---
bq. perhaps ping dev@hbase for volunteers
Thanks for reminder.
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680442#comment-16680442
]
Sean Busbey commented on HBASE-21255:
-
> I will commit it late this day if no further comments.
I
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679232#comment-16679232
]
Reid Chan commented on HBASE-21255:
---
I will commit it late this day if no further comments.
Since
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678066#comment-16678066
]
Reid Chan commented on HBASE-21255:
---
Hoping more comments.
> [acl] Refactor TablePermission into
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677741#comment-16677741
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677569#comment-16677569
]
Reid Chan commented on HBASE-21255:
---
v7 changes visibility of new method
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676057#comment-16676057
]
Reid Chan commented on HBASE-21255:
---
Thanks Sean!
Would you mind taking a look at
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675484#comment-16675484
]
Sean Busbey commented on HBASE-21255:
-
the precommit failures were probably the openjdk / surefire
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675051#comment-16675051
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675006#comment-16675006
]
Reid Chan commented on HBASE-21255:
---
ping sir [~stack], do you have free cycles to give review?
>
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672506#comment-16672506
]
Reid Chan commented on HBASE-21255:
---
Failed UTs are not related, v5 addressed Duo's comment against
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671722#comment-16671722
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670026#comment-16670026
]
Duo Zhang commented on HBASE-21255:
---
Seems all the recent pre commit builds are broken...
> [acl]
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670016#comment-16670016
]
Duo Zhang commented on HBASE-21255:
---
Seems all the recent pre commit builds are broken...
> [acl]
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669979#comment-16669979
]
Reid Chan commented on HBASE-21255:
---
All modified UTs passed on local, and ShadedAccessControlUtil's
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669973#comment-16669973
]
Reid Chan commented on HBASE-21255:
---
ping [~busbey]
{code}
[ERROR] Error occurred in starting fork,
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669955#comment-16669955
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669254#comment-16669254
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668354#comment-16668354
]
Reid Chan commented on HBASE-21255:
---
Let's see what will QA says before updating RB.
> [acl] Refactor
36 matches
Mail list logo
