[jira] [Commented] (HBASE-21341) DeadServer shouldn't import unshaded Preconditions

2018-10-19 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656848#comment-16656848 ] Sean Busbey commented on HBASE-21341: - what version(s) of enforcer does the rule exist for? what's

[jira] [Commented] (HBASE-21341) DeadServer shouldn't import unshaded Preconditions

2018-10-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656145#comment-16656145 ] Duo Zhang commented on HBASE-21341: --- I do no think checkstyle is strong enough. We sometimes want to

[jira] [Commented] (HBASE-21341) DeadServer shouldn't import unshaded Preconditions

2018-10-18 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655891#comment-16655891 ] Sean Busbey commented on HBASE-21341: - I thought we had a checkstyle guard against this getting in.

[jira] [Commented] (HBASE-21341) DeadServer shouldn't import unshaded Preconditions

2018-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655837#comment-16655837 ] Hadoop QA commented on HBASE-21341: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem