[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724947#comment-16724947 ] Hudson commented on HBASE-21514: Results for branch branch-2 [build #1566 on

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724927#comment-16724927 ] Hudson commented on HBASE-21514: Results for branch master [build #671 on

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724678#comment-16724678 ] stack commented on HBASE-21514: --- Thanks [~zghaobac] I put a +1 over on the HBASE-21498. Good find. >

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724670#comment-16724670 ] Guanghao Zhang commented on HBASE-21514: {quote}There is risk with a patch of this size. {quote}

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724227#comment-16724227 ] stack commented on HBASE-21514: --- Too late for next 2.0.4 and 2.1.2 RCs. This is a very nice patch though.

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724114#comment-16724114 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724068#comment-16724068 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723962#comment-16723962 ] Anoop Sam John commented on HBASE-21514: Thanks for the nice cleanup/ improvement.. Similar is

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723947#comment-16723947 ] Hudson commented on HBASE-21514: Results for branch master [build #669 on

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723836#comment-16723836 ] Guanghao Zhang commented on HBASE-21514: Add a addendum patch to address [~anoop.hbase]

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723829#comment-16723829 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-17 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723775#comment-16723775 ] Guanghao Zhang commented on HBASE-21514: Ping [~stack] for branch-2.1 and branch-2.0. :) >

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-17 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723707#comment-16723707 ] Guanghao Zhang commented on HBASE-21514: All ut passed. Will fix the checkstyle warnings when

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722785#comment-16722785 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-16 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722700#comment-16722700 ] Duo Zhang commented on HBASE-21514: --- +1. > Refactor CacheConfig > > >

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-16 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722696#comment-16722696 ] Guanghao Zhang commented on HBASE-21514: Rebased and add 014 patch. Any more comments?

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722641#comment-16722641 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721389#comment-16721389 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-14 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721061#comment-16721061 ] Guanghao Zhang commented on HBASE-21514: Add 013 patch to fix the checkstyle and failed ut. >

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719899#comment-16719899 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719744#comment-16719744 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-12 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719632#comment-16719632 ] Guanghao Zhang commented on HBASE-21514: Ping [~anoop.hbase] [~stack] [~Apache9] for reviewing.

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718965#comment-16718965 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-12 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718598#comment-16718598 ] Guanghao Zhang commented on HBASE-21514: The failed ut timeout. Seems the ut run slowly because

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718548#comment-16718548 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-06 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712259#comment-16712259 ] Guanghao Zhang commented on HBASE-21514: The javac warning not introduced by this patch. >

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711416#comment-16711416 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711206#comment-16711206 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-05 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710447#comment-16710447 ] Anoop Sam John commented on HBASE-21514: Added few comments in RB.. But only half way through

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-05 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710123#comment-16710123 ] Guanghao Zhang commented on HBASE-21514: Ping [~stack]  [~Apache9] [~anoop.hbase] for reviewing.

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-05 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710122#comment-16710122 ] Guanghao Zhang commented on HBASE-21514: Do we have annotations to fix the checkstyle warning?

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709932#comment-16709932 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-05 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709732#comment-16709732 ] Guanghao Zhang commented on HBASE-21514: Ping [~anoop.hbase] for reviewing. > Refactor

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708630#comment-16708630 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708400#comment-16708400 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706787#comment-16706787 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706109#comment-16706109 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-12-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705793#comment-16705793 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705562#comment-16705562 ] Hadoop QA commented on HBASE-21514: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-11-30 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704553#comment-16704553 ] Guanghao Zhang commented on HBASE-21514: Add a 001 patch to see the HADOOP QA result... >

[jira] [Commented] (HBASE-21514) Refactor CacheConfig

2018-11-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699915#comment-16699915 ] Anoop Sam John commented on HBASE-21514: When we have a test Mini cluster with 1+ RSs, ideally