[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449359#comment-17449359 ] michaelli commented on HBASE-22274: --- [~xucang]  Hi Cang, do you know when was this parm added

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837757#comment-16837757 ] Hudson commented on HBASE-22274: Results for branch branch-2.1 [build #1131 on

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837570#comment-16837570 ] Hudson commented on HBASE-22274: Results for branch master [build #997 on

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837542#comment-16837542 ] Hudson commented on HBASE-22274: Results for branch branch-2 [build #1881 on

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837500#comment-16837500 ] Hudson commented on HBASE-22274: Results for branch branch-2.2 [build #249 on

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837462#comment-16837462 ] Hudson commented on HBASE-22274: Results for branch branch-1.4 [build #788 on

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837158#comment-16837158 ] Hudson commented on HBASE-22274: Results for branch branch-1 [build #816 on

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837048#comment-16837048 ] Peter Somogyi commented on HBASE-22274: --- Added fixed versions. > Cell size limit check on append

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836967#comment-16836967 ] Xu Cang commented on HBASE-22274: - pushed to branch-2, branch-2.1, branch-2.2 > Cell size limit check

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836874#comment-16836874 ] Xu Cang commented on HBASE-22274: - pushed to branch-1.4 > Cell size limit check on append should

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836868#comment-16836868 ] Xu Cang commented on HBASE-22274: - https://issues.apache.org/jira/browse/HBASE-18043 was the one

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836860#comment-16836860 ] Xu Cang commented on HBASE-22274: - pushed patch to branch-1. > Cell size limit check on append should

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836864#comment-16836864 ] Xu Cang commented on HBASE-22274: - pushed to master branch > Cell size limit check on append should

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836835#comment-16836835 ] HBase QA commented on HBASE-22274: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836780#comment-16836780 ] Andrew Purtell commented on HBASE-22274: bq. Reading code in this class "RSRpcServices", I can

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836777#comment-16836777 ] Xu Cang commented on HBASE-22274: - When cell size exceeds the limit, we always throw exception like this

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836766#comment-16836766 ] Xu Cang commented on HBASE-22274: - Moving unit test fix to 

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836731#comment-16836731 ] Andrew Purtell commented on HBASE-22274: bq. There are 88 'createTable' calls in

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836729#comment-16836729 ] Andrew Purtell commented on HBASE-22274: v4 patch lgtm The test issue is clearer now. One

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836551#comment-16836551 ] Xu Cang commented on HBASE-22274: - [~apurtell]  , [~abhishek.chouhan] could you please review this patch 

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836276#comment-16836276 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836189#comment-16836189 ] Xu Cang commented on HBASE-22274: - Fixed 2 checkstyle issues. First 2 checkstyle issues, "indentation

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836094#comment-16836094 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835975#comment-16835975 ] Xu Cang commented on HBASE-22274: - quick update on this ( I didn't discard this one :)) There are 88

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829680#comment-16829680 ] Andrew Purtell commented on HBASE-22274: {quote}So, I don't understand why Put can sometimes

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827385#comment-16827385 ] Xu Cang commented on HBASE-22274: - The test #testCheckAndDeleteWithCompareOp is flaky. It fails at

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827156#comment-16827156 ] Xu Cang commented on HBASE-22274: - Agreed. [~apurtell]  I will investigate.  > Cell size limit check

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826549#comment-16826549 ] Andrew Purtell commented on HBASE-22274: Pointing at this commit isn't useful. If this is really

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826451#comment-16826451 ] Xu Cang commented on HBASE-22274: - I checked out code on branch-1 on this commit: 

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825595#comment-16825595 ] Xu Cang commented on HBASE-22274: - Fully understand and agree with you that we should figure out the

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825592#comment-16825592 ] Andrew Purtell commented on HBASE-22274: Just to be clear I am not saying this change

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825590#comment-16825590 ] Xu Cang commented on HBASE-22274: - Hmm. I was talking about branch-1 .  Will check more. > Cell size

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825589#comment-16825589 ] Andrew Purtell commented on HBASE-22274: I applied this patch, the test failed. I checked out

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825584#comment-16825584 ] Xu Cang commented on HBASE-22274: - I did a bisect and found 

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825552#comment-16825552 ] Xu Cang commented on HBASE-22274: - [~apurtell] the failure is introduced by this: commit

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825486#comment-16825486 ] Andrew Purtell commented on HBASE-22274: That test failure in precommit may be short circuiting

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825474#comment-16825474 ] Xu Cang commented on HBASE-22274: - OK. thanks [~apurtell] Thanks for the review [~abhishek.chouhan] >

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825446#comment-16825446 ] Andrew Purtell commented on HBASE-22274: I'm working in this general area and on branch-1 in

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825420#comment-16825420 ] Abhishek Singh Chouhan commented on HBASE-22274: Lgtm +1. Thanks [~xucang] > Cell size

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824708#comment-16824708 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824647#comment-16824647 ] Xu Cang commented on HBASE-22274: - [~abhishek.chouhan] please review patch 03 for master branch, based

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824581#comment-16824581 ] HBase QA commented on HBASE-22274: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824582#comment-16824582 ] Xu Cang commented on HBASE-22274: - Submitting patch 03 for mater branch, moving the check to an earlier

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824526#comment-16824526 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824420#comment-16824420 ] Xu Cang commented on HBASE-22274: - adding patch for branch-1. Let hadoop-qa run.  > Cell size limit

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824392#comment-16824392 ] Xu Cang commented on HBASE-22274: - The unit tests' failure looks irrelevant to this patch.  > Cell size

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824332#comment-16824332 ] Andrew Purtell commented on HBASE-22274: +1 Please port back to branch-1 too, thanks [~xucang]

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823645#comment-16823645 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823454#comment-16823454 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823253#comment-16823253 ] Xu Cang commented on HBASE-22274: - submitting patch 02 to fix checkstyle issue.   FYI [~apurtell]

[jira] [Commented] (HBASE-22274) Cell size limit check on append should consider cell's previous size.

[ https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822305#comment-16822305 ] HBase QA commented on HBASE-22274: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem