[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845836#comment-16845836 ] binlijin commented on HBASE-22433: -- After HBASE-22447/HBASE-22441 we need to make a decision to whether

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844624#comment-16844624 ] binlijin commented on HBASE-22433: -- [~anoop.hbase], ok , do it in HBASE-22447. > Corrupt hfile data >

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844587#comment-16844587 ] Anoop Sam John commented on HBASE-22433: Good. Ya the ref count checking within the write lock

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843747#comment-16843747 ] binlijin commented on HBASE-22433: -- A draft patch for the corrupt, we need to check the ref count when

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843720#comment-16843720 ] ramkrishna.s.vasudevan commented on HBASE-22433: Is this some how related to

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843619#comment-16843619 ] Zheng Hu commented on HBASE-22433: -- So will need an extra refCnt check within the write lock context

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843599#comment-16843599 ] binlijin commented on HBASE-22433: -- The returnBlock may corrupt the data, there is no synchronized

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843598#comment-16843598 ] Zheng Hu commented on HBASE-22433: -- bq. because there is no lock between the check(if

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843592#comment-16843592 ] binlijin commented on HBASE-22433: -- HBASE-20789/HBASE-20447 caching an already cached block introduce

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843591#comment-16843591 ] binlijin commented on HBASE-22433: -- bq. We have a BucketCache#returnBlock here because the

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843585#comment-16843585 ] Zheng Hu commented on HBASE-22433: -- bq. we need first to revert HBASE-20789/HBASE-20447 and as Duo

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843582#comment-16843582 ] Zheng Hu commented on HBASE-22433: -- bq. Seems an unwanted refCount decr happening here which causing

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843440#comment-16843440 ] binlijin commented on HBASE-22433: -- [~Apache9] [~openinx], what do you think? > Corrupt hfile data >

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843328#comment-16843328 ] binlijin commented on HBASE-22433: -- [~anoop.hbase] Yes, you are correct, i think we need first to

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842896#comment-16842896 ] Anoop Sam John commented on HBASE-22433: Seems related issues.. For checking whether an already

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841970#comment-16841970 ] binlijin commented on HBASE-22433: -- Looks like the NullPointerException is another concurrent problems.

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841937#comment-16841937 ] binlijin commented on HBASE-22433: -- {code} 2019-05-17 12:42:53,319 WARN

[jira] [Commented] (HBASE-22433) Corrupt hfile data

[ https://issues.apache.org/jira/browse/HBASE-22433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841936#comment-16841936 ] binlijin commented on HBASE-22433: -- {code} 2019-05-17 12:42:53,235 WARN [StoreFileOpenerThread-o-1]