[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-12-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990932#comment-16990932 ] Viraj Jasani commented on HBASE-22457: -- {quote} # detect run-away refCount by comparing any

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847806#comment-16847806 ] Andrew Purtell commented on HBASE-22457: [~lhofhansl] do you want to really submit that patch?

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846265#comment-16846265 ] Andrew Purtell commented on HBASE-22457: I opened subtask HBASE-22460 (Reopen a region if store

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846262#comment-16846262 ] Andrew Purtell commented on HBASE-22457: Java offers Closable and AutoClosable interfaces that

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846258#comment-16846258 ] Lars Hofhansl commented on HBASE-22457: --- > No, but this is no more or less fast then the close

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846253#comment-16846253 ] Andrew Purtell commented on HBASE-22457: bq. I do like your idea. Can we do a fast close without

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846252#comment-16846252 ] Andrew Purtell commented on HBASE-22457: bq. What I'm really looking for is a structural fix

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846249#comment-16846249 ] Andrew Purtell commented on HBASE-22457: Random patch lgtm One thought: {code} + if (rsh.s

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846172#comment-16846172 ] Lars Hofhansl commented on HBASE-22457: --- Some random things that didn't quite look right. >

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846161#comment-16846161 ] Lars Hofhansl commented on HBASE-22457: --- Oh, it's a hack for sure and, as you point out, might

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846109#comment-16846109 ] Andrew Purtell commented on HBASE-22457: [~lhofhansl] bq. Are there any "safepoints"? I.e.

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846100#comment-16846100 ] Andrew Purtell commented on HBASE-22457: bq. The Phoenix ones should be rare. In our case we are

[jira] [Commented] (HBASE-22457) Harden the HBase HFile reader reference counting

2019-05-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846075#comment-16846075 ] Lars Hofhansl commented on HBASE-22457: --- One idea is: Are there any "safepoints"? I.e. points