[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864004#comment-16864004 ] Anoop Sam John commented on HBASE-22566: Ah I see we have HBASE-21284 for forward porting > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch, > HBASE-22566.002.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864002#comment-16864002 ] Anoop Sam John commented on HBASE-22566: I also came here to say that only compaction is throughput controlled. Mind changing the subject and desc of the issue? So for 2.x lines also we will increase the Compaction throughput limits as done for 1.x? > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch, > HBASE-22566.002.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863634#comment-16863634 ] Andrew Purtell commented on HBASE-22566: Related, I've increased defaults for PressureAware*ThroughputController once already in branch-1 for 1.5.0 and might do so again, to prevent what could be considered surprising regressions. This was HBASE-21000 > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch, > HBASE-22566.002.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[
https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862660#comment-16862660
]
Hudson commented on HBASE-22566:
Results for branch branch-2.1
[build #1260 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1260/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1260//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1260//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1260//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Call out default compaction and flush throttling for 2.x in Book
>
>
> Key: HBASE-22566
> URL: https://issues.apache.org/jira/browse/HBASE-22566
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch,
> HBASE-22566.002.patch
>
>
> We had it in the release notes, but it didn't make it into the upgrade path
> chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that
> compactions and flushes are now limited in throughput per RegionServer.
> Came as a surprise to me the other day - I'm sure I won't be the last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[
https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862653#comment-16862653
]
Hudson commented on HBASE-22566:
Results for branch branch-2.2
[build #358 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/358/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/358//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/358//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/358//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Call out default compaction and flush throttling for 2.x in Book
>
>
> Key: HBASE-22566
> URL: https://issues.apache.org/jira/browse/HBASE-22566
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch,
> HBASE-22566.002.patch
>
>
> We had it in the release notes, but it didn't make it into the upgrade path
> chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that
> compactions and flushes are now limited in throughput per RegionServer.
> Came as a surprise to me the other day - I'm sure I won't be the last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[
https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862617#comment-16862617
]
Hudson commented on HBASE-22566:
Results for branch master
[build #1130 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1130/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1130//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1130//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1130//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Call out default compaction and flush throttling for 2.x in Book
>
>
> Key: HBASE-22566
> URL: https://issues.apache.org/jira/browse/HBASE-22566
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch,
> HBASE-22566.002.patch
>
>
> We had it in the release notes, but it didn't make it into the upgrade path
> chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that
> compactions and flushes are now limited in throughput per RegionServer.
> Came as a surprise to me the other day - I'm sure I won't be the last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[
https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862613#comment-16862613
]
Hudson commented on HBASE-22566:
Results for branch branch-2
[build #1988 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1988/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1988//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1988//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1988//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Call out default compaction and flush throttling for 2.x in Book
>
>
> Key: HBASE-22566
> URL: https://issues.apache.org/jira/browse/HBASE-22566
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch,
> HBASE-22566.002.patch
>
>
> We had it in the release notes, but it didn't make it into the upgrade path
> chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that
> compactions and flushes are now limited in throughput per RegionServer.
> Came as a surprise to me the other day - I'm sure I won't be the last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862377#comment-16862377 ] Sean Busbey commented on HBASE-22566: - +1 > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch, > HBASE-22566.002.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[
https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862276#comment-16862276
]
HBase QA commented on HBASE-22566:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 8m
0s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
53s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/526/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22566 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971600/HBASE-22566.002.patch
|
| Optional Tests | dupname asflicense refguide |
| uname | Linux 63a8c408a42a 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ef44f30006 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/526/artifact/patchprocess/branch-site/book.html
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/526/artifact/patchprocess/whitespace-eol.txt
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/526/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 85 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/526/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Call out default compaction and flush throttling for 2.x in Book
>
>
> Key: HBASE-22566
> URL: https://issues.apache.org/jira/browse/HBASE-22566
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch,
> HBASE-22566.002.patch
>
>
> We had it in the release notes, but it didn't make it into the upgrade path
> chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that
> compactions and flushes are now limited in throughput per RegionServer.
> Came as a surprise to me the other day - I'm sure I won't be the last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862250#comment-16862250 ] Josh Elser commented on HBASE-22566: .002 updates the doc. Thanks for the catch, JMS! > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch, > HBASE-22566.002.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[
https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862242#comment-16862242
]
Josh Elser commented on HBASE-22566:
{quote}Any reason to limit the flush speed by default? That's surprising, no?
{quote}
Actually, seems like I never looked close enough at
FlushThroughputControllerFactory. I thought the
PressureAwareFlushThroughputController was the default (like the
PressureAwareCompactionThroughputController was), but it is not. Doc patch is
wrong :)
> Call out default compaction and flush throttling for 2.x in Book
>
>
> Key: HBASE-22566
> URL: https://issues.apache.org/jira/browse/HBASE-22566
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch
>
>
> We had it in the release notes, but it didn't make it into the upgrade path
> chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that
> compactions and flushes are now limited in throughput per RegionServer.
> Came as a surprise to me the other day - I'm sure I won't be the last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862239#comment-16862239 ] Jean-Marc Spaggiari commented on HBASE-22566: - Any reason to limit the flush speed by default? That's surprising, no? > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862188#comment-16862188 ] Josh Elser commented on HBASE-22566: Attaching a screen grab of the rendered content from the book. > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Attachments: HBASE-22566-updated-content.png, HBASE-22566.001.patch > > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22566) Call out default compaction and flush throttling for 2.x in Book
[ https://issues.apache.org/jira/browse/HBASE-22566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861166#comment-16861166 ] Josh Elser commented on HBASE-22566: FYSA, [~busbey], since I had chatted with you about this. > Call out default compaction and flush throttling for 2.x in Book > > > Key: HBASE-22566 > URL: https://issues.apache.org/jira/browse/HBASE-22566 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > > We had it in the release notes, but it didn't make it into the upgrade path > chapter of the Book ([https://hbase.apache.org/book.html#upgrade2.0]) that > compactions and flushes are now limited in throughput per RegionServer. > Came as a surprise to me the other day - I'm sure I won't be the last. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
