[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904366#comment-16904366 ] Hudson commented on HBASE-22623: Results for branch branch-2 [build #2158 on

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904359#comment-16904359 ] Hudson commented on HBASE-22623: Results for branch branch-1 [build #1000 on

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904345#comment-16904345 ] Hudson commented on HBASE-22623: Results for branch master [build #1324 on

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904150#comment-16904150 ] Andrew Purtell commented on HBASE-22623: Thanks Stack, agree, follow up issues are most welcome

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904149#comment-16904149 ] Andrew Purtell commented on HBASE-22623: Thanks Geoffrey. I will have time to commit this later

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904119#comment-16904119 ] stack commented on HBASE-22623: --- bq. "...but what I'm trying to understand is why. " Because we were

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904052#comment-16904052 ] Geoffrey Jacoby commented on HBASE-22623: - Branch-1 backport PR is up at 470. > Add

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904022#comment-16904022 ] Geoffrey Jacoby commented on HBASE-22623: - [~apurtell] branch-1 backport coming in the next hour

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904017#comment-16904017 ] Andrew Purtell commented on HBASE-22623: [~gjacoby] Did you say you have a branch-1 backport?

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-09 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904015#comment-16904015 ] Andrew Purtell commented on HBASE-22623: Ok, good for commit then. Will commit shortly. > Add

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-08 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903256#comment-16903256 ] Andrew Purtell commented on HBASE-22623: Waiting 24 hours for time zone turn around. > Add

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-08 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903253#comment-16903253 ] Andrew Purtell commented on HBASE-22623: I sent an email with the subject "Coprocessors, clean

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-08 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903241#comment-16903241 ] Andrew Purtell commented on HBASE-22623: Just to be clear because I used the word "hostile"

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-08 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903233#comment-16903233 ] Andrew Purtell commented on HBASE-22623: I am merging the current PR and [~gjacoby] has

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-08 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903227#comment-16903227 ] Andrew Purtell commented on HBASE-22623: I don't think the new method should be deprecated. It

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902674#comment-16902674 ] Duo Zhang commented on HBASE-22623: --- I mean the newly added coprocessor method. Let me comment on

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902673#comment-16902673 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - I apologize for being rude in my last

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902621#comment-16902621 ] Duo Zhang commented on HBASE-22623: --- Oh, I misread the patch. I thought it is in WALObserver. Sorry.

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902619#comment-16902619 ] Andrew Purtell commented on HBASE-22623: I think we’re just having a bit of a miscommunication.

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902615#comment-16902615 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - the new method is in RegionObserver, and

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902616#comment-16902616 ] Andrew Purtell commented on HBASE-22623: This patch does place the method in RegionObserver.

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902612#comment-16902612 ] Duo Zhang commented on HBASE-22623: --- {quote} Oh sorry. Please pardon the brevity. Not at home right

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902611#comment-16902611 ] Andrew Purtell commented on HBASE-22623: I think pre WAL write is in WALObserver but is not

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902608#comment-16902608 ] Geoffrey Jacoby commented on HBASE-22623: - 1. There does not appear to be a preWALWrite in

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902605#comment-16902605 ] Andrew Purtell commented on HBASE-22623: The thread context is not the RPC thread. Without this

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902603#comment-16902603 ] Duo Zhang commented on HBASE-22623: --- Can anyone answer my first question? I've asked several times,

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902602#comment-16902602 ] Andrew Purtell commented on HBASE-22623: Oh sorry. Please pardon the brevity. Not at home right

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902598#comment-16902598 ] Andrew Purtell commented on HBASE-22623: It is about the WALkey for earlier described reasons. I

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902590#comment-16902590 ] Duo Zhang commented on HBASE-22623: --- Two problems: 1. Why not just use the old preWALWrite method?

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902517#comment-16902517 ] Geoffrey Jacoby commented on HBASE-22623: - [~apurtell] I have modified the patch to revert the

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902242#comment-16902242 ] Andrew Purtell commented on HBASE-22623: Also for clarification I think we can include a WALEdit

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902239#comment-16902239 ] Andrew Purtell commented on HBASE-22623: For the record I am not -1 to the previous version of

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902234#comment-16902234 ] Andrew Purtell commented on HBASE-22623: I have to agree. I can call System.exit() from a

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902136#comment-16902136 ] Geoffrey Jacoby commented on HBASE-22623: - So, as things stand now, [~apurtell] is -1 to a

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901820#comment-16901820 ] Anoop Sam John commented on HBASE-22623: That will be too much of a work for such a need IMHO.

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901797#comment-16901797 ] Duo Zhang commented on HBASE-22623: --- In the preIncrement and preAppend, you can return a Result so

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901793#comment-16901793 ] Anoop Sam John commented on HBASE-22623: preAppend/Increment CP APIs takes Append/Increment

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901757#comment-16901757 ] Duo Zhang commented on HBASE-22623: --- {quote} Because MiniBatchOperationInProgress and related CP APIs

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901754#comment-16901754 ] Duo Zhang commented on HBASE-22623: --- Anyway I'm -1 on adding a new method which is just a copy of an

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901694#comment-16901694 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - any coprocessor hook can create data

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901677#comment-16901677 ] Anoop Sam John commented on HBASE-22623: In this discussion one comment on patch come up. The

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901676#comment-16901676 ] Duo Zhang commented on HBASE-22623: --- At least Thread.sleep and System.exit will not mess up the data

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901668#comment-16901668 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - that seems like an argument that the new

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901629#comment-16901629 ] Duo Zhang commented on HBASE-22623: --- For example, we will write some marker edits to WAL, and it will

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901627#comment-16901627 ] Andrew Purtell commented on HBASE-22623: I also would like to understand what will be “messed

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901624#comment-16901624 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - could you please go into more detail on

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901612#comment-16901612 ] Duo Zhang commented on HBASE-22623: --- The problem here is the WALEdit, it has set methods which could

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901311#comment-16901311 ] Andrew Purtell commented on HBASE-22623: Thanks Anoop. > Add RegionObserver coprocessor hook

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901298#comment-16901298 ] Anoop Sam John commented on HBASE-22623: Ping [~Apache9]. He did most of the CP cleanup stuff

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901262#comment-16901262 ] Andrew Purtell commented on HBASE-22623: The explicit intent of the new hook is to modify or

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-06 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900800#comment-16900800 ] Anoop Sam John commented on HBASE-22623: The CP cleanup was a larger activity. Say some CP API

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900506#comment-16900506 ] Andrew Purtell commented on HBASE-22623: bq. WALEdit preWALAppend(WALKey,

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-05 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900145#comment-16900145 ] Geoffrey Jacoby commented on HBASE-22623: - So, I see that the immutability of the Region-created

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-05 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899856#comment-16899856 ] Anoop Sam John commented on HBASE-22623: As part of CP clean up for 2.0 I believe we have added

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-08-04 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899716#comment-16899716 ] Geoffrey Jacoby commented on HBASE-22623: - The current patch up for evaluation at PR 390 creates

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-16 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886410#comment-16886410 ] Andrew Purtell commented on HBASE-22623: {quote}instrumentation for the two code paths could be

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-16 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886408#comment-16886408 ] Andrew Purtell commented on HBASE-22623: {quote}The signatures for the Append/Increment coprocs

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-16 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886378#comment-16886378 ] Geoffrey Jacoby commented on HBASE-22623: - What I meant is that for ease of evaluation and to

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-16 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886361#comment-16886361 ] Andrew Purtell commented on HBASE-22623: {quote}They're mostly unrelated changes though, so it

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-16 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886347#comment-16886347 ] Geoffrey Jacoby commented on HBASE-22623: - I think Append and Increment use a different code

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-16 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886322#comment-16886322 ] Andrew Purtell commented on HBASE-22623: {quote} MiniBatchOperationInProgress object that gets

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-15 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885696#comment-16885696 ] Geoffrey Jacoby commented on HBASE-22623: - Upon looking more closely, it doesn't seem like my

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-08 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880747#comment-16880747 ] Geoffrey Jacoby commented on HBASE-22623: - As an alternative to adding