[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908442#comment-16908442
]
Sakthi commented on HBASE-22843:
Thanks for the review comments [~stack]. The PR has been merged. Closing this
jira now.
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907523#comment-16907523
]
Sakthi commented on HBASE-22843:
[~stack], I plan to do the former one. I have my draft patch as a PR (#14)
which is linked over here. Could you please take a look & guide if I have
strayed away from the path? :)
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906656#comment-16906656
]
stack commented on HBASE-22843:
---
[~psomogyi] If change is to the HBCK2 local HBaseFsck... it is an internal
affair. If it is relying on serverside HBaseFsck, then yeah, will break going
to older versions. My understanding is [~jatsakthi] is doing the former
(correct me if I am wrong sir).
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906593#comment-16906593
]
Peter Somogyi commented on HBASE-22843:
---
#2: Will HBCK2 be compatible with pre-2.1.6 versions if HBCK2 will also make
the change and move to List getMergeRegions(Cell[] cells)?
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906592#comment-16906592
]
stack commented on HBASE-22843:
---
Thanks.
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906583#comment-16906583
]
Sakthi commented on HBASE-22843:
Yes [~stack], I think we can carry on with RCs now. :)
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906574#comment-16906574
]
stack commented on HBASE-22843:
---
On your suggested change, makes sense that there is an echo of HBCK1 changes in
HBCK2 (hopefully changes in hbck1 server-side go to zero soon..)
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906567#comment-16906567
]
stack commented on HBASE-22843:
---
[~jatsakthi] just checking, we can go ahead w/ making RCs now? You will take
care of the other issues by copying code local to HBCK2? (You can't rely on the
new methods because then you only work w/ the coming RCs... right?). Thanks.
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906508#comment-16906508
]
Hadoop QA commented on HBASE-22843:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
31s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
46s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 56s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
54s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 67m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-488/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/488 |
| JIRA Issue | HBASE-22843 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 813f1b35799f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-488/out/precommit/personality/provided.sh
|
| git revision | master / 8c1edb3bba |
| Default Java | 1.8.0_181 |
| Test Results |
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906437#comment-16906437
]
Sakthi commented on HBASE-22843:
Sure, [~stack] let me create a new one.
For #2, I was thinking of pulling the code local from HBaseFsck as of now like
this:
{code:java}
-PairOfSameType mergeRegions =
MetaTableAccessor.getMergeRegions(result);
-for (RegionInfo mergeRegion : new RegionInfo[] {
-mergeRegions.getFirst(), mergeRegions.getSecond() }) {
-if (mergeRegion != null) {
-// This region is already been merged
-HbckRegionInfo hbInfo = getOrCreateInfo(mergeRegion.getEncodedName());
-hbInfo.setMerged(true);
-}
+List mergeParents =
MetaTableAccessor.getMergeRegions(result.rawCells());
+if (mergeParents != null) {
+for (RegionInfo mergeRegion : mergeParents) {
+ if (mergeRegion != null) {
+// This region is already being merged
+ HbckRegionInfo hbInfo = getOrCreateInfo(mergeRegion.getEncodedName());
+ hbInfo.setMerged(true);
+ }
}{code}
Our hbck2 doesn't support multi-region merge yet, right (?). In that case, let
me look at enabling multi-region merge from hbck2 parallely to see what else
comes out.
Thanks for your comments Stack.
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906431#comment-16906431
]
stack commented on HBASE-22843:
---
Usually you can make subissues but this is already a subissue and jira doesn't
allow sub-of-sub. Make a new one and link here I'd say sir. To be clear on #2,
you are going to pull the code local? What about running multi-region merge
from hbck2? Where would that go? We'd have to probe to see if the server
supported multi-region. That can be a follow-on. Can get fixes in first.
Thanks. I made this a blocker.
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906416#comment-16906416
]
Sakthi commented on HBASE-22843:
Yes, Stack. for #1 we need a change in hbase (let me put up a patch for it
asap), for #2 & #3 we can do off with hbase-operator-tools itself. So should
the change for hbase repo be separate jira? or can I just refer to that also as
HBASE-22843 (i.e. this one. that way in both repos we would have two different
commits under same reference Jira).
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906411#comment-16906411
]
stack commented on HBASE-22843:
---
Yeah, @InterfaceAudience.Private is on MTA.
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906409#comment-16906409
]
stack commented on HBASE-22843:
---
Good on you Sakthi.
On #1, it was this change that changed the access (by me). It is not in a
release yet so we could change it back if we do it quick?
HBASE-22777 Add a multi-region merge (for fixing overlaps) Makes
MergeTableRegionsProcedure do more than just two regions at a time. Compatible
as MTRP was done considering one day it'd do more than two at a time. Changes
hardcoded assumption that merge parent regions are named mergeA and mergeB in a
column on the resultant region. Instead can have N columns on the merged
region, one for each parent merged. Column qualifiers all being with 'merge'.
Most of code below is undoing the assumption that there are two parents on a
merge only.
Same for #2.
On #3, it was changed by openinx in HBASE-22758 Remove the unneccesary info cf
deletion in DeleteTableProcedure#deleteFromMeta (#424)
This has not made a release yet.
Trouble with depending on hbase for these methods is that then HBCK2 is tied
tightly to particular patch releases. I'd say in future we should copy the
methods local. For now I think we should change hbase itself (quickly -- smile).
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
