[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[
https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921031#comment-16921031
]
Hudson commented on HBASE-22905:
Results for branch branch-2.1
[build #1548 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1548/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1548//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1548//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1548//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
> --
>
> Key: HBASE-22905
> URL: https://issues.apache.org/jira/browse/HBASE-22905
> Project: HBase
> Issue Type: Improvement
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22905-master-v1.patch
>
>
> Currently BlockingRpcConnection use ByteBufferOutputStream to serialize
> CellBlock which involve temp ByteBuffer allocation, we can replace it with
> netty’s ByteBufOutputStream, just like what
> NettyRpcDuplexHandler#writeRequest doing
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[
https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921025#comment-16921025
]
Hudson commented on HBASE-22905:
Results for branch branch-2.2
[build #564 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/564/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/564//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/564//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/564//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
> --
>
> Key: HBASE-22905
> URL: https://issues.apache.org/jira/browse/HBASE-22905
> Project: HBase
> Issue Type: Improvement
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22905-master-v1.patch
>
>
> Currently BlockingRpcConnection use ByteBufferOutputStream to serialize
> CellBlock which involve temp ByteBuffer allocation, we can replace it with
> netty’s ByteBufOutputStream, just like what
> NettyRpcDuplexHandler#writeRequest doing
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[
https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921024#comment-16921024
]
Hudson commented on HBASE-22905:
Results for branch branch-2
[build #2216 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2216/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2216//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2216//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2216//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
> --
>
> Key: HBASE-22905
> URL: https://issues.apache.org/jira/browse/HBASE-22905
> Project: HBase
> Issue Type: Improvement
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22905-master-v1.patch
>
>
> Currently BlockingRpcConnection use ByteBufferOutputStream to serialize
> CellBlock which involve temp ByteBuffer allocation, we can replace it with
> netty’s ByteBufOutputStream, just like what
> NettyRpcDuplexHandler#writeRequest doing
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[
https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921014#comment-16921014
]
Hudson commented on HBASE-22905:
Results for branch master
[build #1388 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1388/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/master/1388//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/master/1388//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/master/1388//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
> --
>
> Key: HBASE-22905
> URL: https://issues.apache.org/jira/browse/HBASE-22905
> Project: HBase
> Issue Type: Improvement
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22905-master-v1.patch
>
>
> Currently BlockingRpcConnection use ByteBufferOutputStream to serialize
> CellBlock which involve temp ByteBuffer allocation, we can replace it with
> netty’s ByteBufOutputStream, just like what
> NettyRpcDuplexHandler#writeRequest doing
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[ https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917397#comment-16917397 ] stack commented on HBASE-22905: --- [~anoop.hbase] [~ramkrishna.s.vasude...@gmail.com] You fellows have opinion here? > Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest > -- > > Key: HBASE-22905 > URL: https://issues.apache.org/jira/browse/HBASE-22905 > Project: HBase > Issue Type: Improvement >Reporter: chenxu >Assignee: chenxu >Priority: Major > Attachments: HBASE-22905-master-v1.patch > > > Currently BlockingRpcConnection use ByteBufferOutputStream to serialize > CellBlock which involve temp ByteBuffer allocation, we can replace it with > netty’s ByteBufOutputStream, just like what > NettyRpcDuplexHandler#writeRequest doing -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[ https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917192#comment-16917192 ] stack commented on HBASE-22905: --- The patch looks good to me. I'd think this would make for some nice allocation savings? Not committing for the moment in case others want to have a look. Nice work [~javaman_chen] > Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest > -- > > Key: HBASE-22905 > URL: https://issues.apache.org/jira/browse/HBASE-22905 > Project: HBase > Issue Type: Improvement >Reporter: chenxu >Assignee: chenxu >Priority: Major > Attachments: HBASE-22905-master-v1.patch > > > Currently BlockingRpcConnection use ByteBufferOutputStream to serialize > CellBlock which involve temp ByteBuffer allocation, we can replace it with > netty’s ByteBufOutputStream, just like what > NettyRpcDuplexHandler#writeRequest doing -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[
https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916348#comment-16916348
]
HBase QA commented on HBASE-22905:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 15s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
47s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/837/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22905 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12978636/HBASE-22905-master-v1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 13e19dbd268c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0438fdc0f6 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/837/testReport/ |
| Max. process+thread count | 293 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/837/console |
|
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[ https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915399#comment-16915399 ] chenxu commented on HBASE-22905: working on it, will upload soon > Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest > -- > > Key: HBASE-22905 > URL: https://issues.apache.org/jira/browse/HBASE-22905 > Project: HBase > Issue Type: Improvement >Reporter: chenxu >Priority: Major > > Currently BlockingRpcConnection use ByteBufferOutputStream to serialize > CellBlock which involve temp ByteBuffer allocation, we can replace it with > netty’s ByteBufOutputStream, just like what > NettyRpcDuplexHandler#writeRequest doing -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
[ https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915139#comment-16915139 ] stack commented on HBASE-22905: --- Do you have a patch [~javaman_chen]? Thanks. > Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest > -- > > Key: HBASE-22905 > URL: https://issues.apache.org/jira/browse/HBASE-22905 > Project: HBase > Issue Type: Improvement >Reporter: chenxu >Priority: Major > > Currently BlockingRpcConnection use ByteBufferOutputStream to serialize > CellBlock which involve temp ByteBuffer allocation, we can replace it with > netty’s ByteBufOutputStream, just like what > NettyRpcDuplexHandler#writeRequest doing -- This message was sent by Atlassian Jira (v8.3.2#803003)
