[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-14 Thread Sean Busbey (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951490#comment-16951490
 ] 

Sean Busbey commented on HBASE-23101:
-

yes, adding a function to an interface is a breaking change for jdk7 because we 
can't provide a default implementation like we can on jdk8. I agree with Andrew 
wrt the severity and justification here. (FWIW, I was also fine adding a method 
and removing the "you probably dont' want to do this" method given the severity 
of the issue.)

>  but Region is Public not LimitedPrivate.

in branch-1.4 it's {{LimitedPrivate(COPROC)}}.

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-14 Thread Sakthi (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951428#comment-16951428
 ] 

Sakthi commented on HBASE-23101:


[~busbey] have added the flag and the RN. Closing this one, as of now. Please 
feel free to reopen if you any changes need to made in the RN or for further 
discussions. :)

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-14 Thread Sakthi (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951416#comment-16951416
 ] 

Sakthi commented on HBASE-23101:


Makes sense [~apurtell], let's add the "incompatible" flag on this one, add a 
RN and close this one, then? as suggested by Sean.

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-14 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951409#comment-16951409
 ] 

Andrew Kyle Purtell commented on HBASE-23101:
-

[~sakthi] Normally no, but they are guidelines, not rules. In this case if the 
old interface is maintained only we can't do the fix, the list of uuids cannot 
be passed through, and so bulk load file replication is seriously broken. The 
severity of the issue in this case warrants an exception IMHO

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-14 Thread Sakthi (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951402#comment-16951402
 ] 

Sakthi commented on HBASE-23101:


[~apurtell] & [~busbey] is *addition* of a function in a Public interface 
(Region) that is marked LimitedPrivate allowed in maintenance releases? It's 
marked as evolving (which means it can be changed in an upcoming minor version 
but not in a maintenance version. If I am not wrong.). The incompatibility with 
*removal* of the function has been dealt with HBASE-23128.   

I think in that case, both 1.4.11 & 1.3.6 releases are effected by this. 

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-14 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951149#comment-16951149
 ] 

Andrew Kyle Purtell commented on HBASE-23101:
-

Is this about HBASE-23128 not being applied to branch-1.4? I just realized I 
didn't commit it there too. See HBASE-23128 . I see it linked here as a related 
issue but Region is Public not LimitedPrivate. 

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-03 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943997#comment-16943997
 ] 

Hudson commented on HBASE-23101:


Results for branch branch-1.4
[build #1044 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1044/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1044//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1044//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1044//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-03 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943538#comment-16943538
 ] 

Hudson commented on HBASE-23101:


Results for branch branch-1
[build #1094 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1094/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1094//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1094//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1094//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-02 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943247#comment-16943247
 ] 

Hudson commented on HBASE-23101:


Results for branch branch-1.3
[build #993 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-02 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943144#comment-16943144
 ] 

Hudson commented on HBASE-23101:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #648 (See 
[https://builds.apache.org/job/HBase-1.3-IT/648/])
HBASE-23101 Backport HBASE-22380 to branch-1 (apurtell: rev 
84f95fc18c6ff7fdc4bf0a39eaa23c94079be643)
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) hbase-protocol/src/main/protobuf/SecureBulkLoad.proto
* (edit) hbase-protocol/src/main/protobuf/WAL.proto
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* (edit) 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* (edit) 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) hbase-protocol/src/main/protobuf/Client.proto
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* (edit) 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java


> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-02 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943134#comment-16943134
 ] 

Andrew Kyle Purtell commented on HBASE-23101:
-

Pushed to branch-1, branch-1.4, and branch-1.3. branch-1.4 just needed regen of 
protobuf. branch-1.3 needed that plus minor fixups in LoadIncrementalHFiles and 
RSRpcServices.

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-02 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943080#comment-16943080
 ] 

Andrew Kyle Purtell commented on HBASE-23101:
-

WAL and replication unit tests pass. New unit TestBulkLoadReplication passes. 
RAT passes. 

In an offline discussion [~larsh] suggested removing the old methods so they 
aren't accidentally called. A possible follow on issue as it would be relevant 
for other branches besides the branch-1s too, and this issue is just for 
backport.

Committing 

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-02 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943001#comment-16943001
 ] 

Andrew Kyle Purtell commented on HBASE-23101:
-

lgtm, will apply if local tests check out

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-02 Thread Wellington Chevreuil (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942964#comment-16942964
 ] 

Wellington Chevreuil commented on HBASE-23101:
--

Thanks [~apurtell], I believe I have a branch-1 working version of HBASE-22380, 
had submitted it in the given PR.

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1

2019-10-01 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942131#comment-16942131
 ] 

Andrew Kyle Purtell commented on HBASE-23101:
-

Made this a blocker for 1.5.0. To release 1.5.0 anyway, first commit a patch 
that disables bulk load replication 

> Backport HBASE-22380 to branch-1
> 
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)